Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAP] Moves incinerator to atmos maint, adds turbine #5522

Merged
merged 9 commits into from Nov 3, 2014
Merged

[MAP] Moves incinerator to atmos maint, adds turbine #5522

merged 9 commits into from Nov 3, 2014

Conversation

ghost
Copy link

@ghost ghost commented Oct 29, 2014

Ever wonder what those reserves of plasma were meant to be used for in atmospherics besides flooding the station? Well, here's something they can be used for!

Added a new port for the atmos mix to flow to
ss 2014-10-28 at 05 15 48

Turbine (new incinerator that powers the partially station if you're PRO ELITE ATMOS TECH LIKE ME)
ss 2014-10-28 at 05 15 35

Old incinerator is now a condemned mix room
ss 2014-10-28 at 05 15 20

@ChangelingRain
Copy link
Contributor

WALLPIPE CLUTTER
It'd be better if it went through space than going through a line of walls, because you could at least use the suit to do stuff to it without causing a breach.

@ghost
Copy link
Author

ghost commented Oct 29, 2014

True. I'll move the pipe to go through space, but that north atmos diverting room is very cluttered.

Alternatively, I could make the maint there 2-wide, but eh...

@ghost
Copy link
Author

ghost commented Oct 29, 2014

ss 2014-10-28 at 05 48 46

Pipes are outside now.

@ChangelingRain
Copy link
Contributor

👍

@ghost
Copy link
Author

ghost commented Oct 29, 2014

@Steelpoint

@optimumtact
Copy link
Member

Is it moveable? Can you set the station on fire with it?

@ghost
Copy link
Author

ghost commented Oct 29, 2014

No and no. But you can power a singulo with it I guess.

@Steelpoint
Copy link
Contributor

Still wish we could put the atmo/scrubber pipe's on the same tile.

At least the new pipes are in space. Great addition.

👍

@Dorsisdwarf
Copy link
Contributor

Can you move where the pipe enters the burn chamber so that it isn't directly underneath an rwall? Pipes underneath rwalls are hitler to fix.

@ghost
Copy link
Author

ghost commented Oct 29, 2014

They're also hitler to break. If that pipe breaks under any circumstances, odds are the wall is broken as well.

@SubtleGraces
Copy link

Very cool! Was wondering if we'd ever get this on box.

The only thing I'd point out is that it might be very difficult to upgrade the second part of the turbine if it's immovable and flanked by automated blast-doors and r-walls. Admittedly a fractional concern, and one that might not be possible to efficiently address (let's be honest, the chances of this seeing an RPD are the same as freezers/heaters/telecomms equipment) but perhaps worth mentioning.

Whoops. Disregard, I am an idiot for mistaking "immovable" for "un-deconstructable."

@ghost
Copy link
Author

ghost commented Oct 29, 2014

Well, you can just open the blast door outside or enter into the burn chamber with an atmos hardsuit if you want to upgrade it.

@Atskadan
Copy link
Contributor

one of my favorite parts of atmos on meta 👍

@TZK13
Copy link

TZK13 commented Oct 30, 2014

This is pretty nitpicky but the disposals outlet for the turbine room launches shit directly at the transit tube for the AI satellite. I'm not sure what the best way to fix that would be though considering if you make it face east it'll just fire at the SE solars instead.

@TZK13
Copy link

TZK13 commented Oct 30, 2014

Another thought I've had from when I would play around with the turbine as an atmos tech on Metastation is that once the incinerator room is moved so close to atmos it basically becomes a second workplace for atmos techs. This makes it even more so with the direct piping from atmospherics with the "mix to incinerator" pipe.

With that it mind why not have this new turbine room require atmospherics access while retaining the old incinerator room the same as it's always been? I realize the feature of burning trash to ashes isn't actually implemented but it was placed nearby to cargo for that sort of IC reasoning wasn't it?

@ghost
Copy link
Author

ghost commented Oct 30, 2014

"I realize the feature of burning trash to ashes isn't actually implemented"

Answered your own question.

@TZK13
Copy link

TZK13 commented Oct 30, 2014

I still feel that the turbine should be at the hands of atmos techs and atmos techs alone especially if and when assistants get maint back so that random people can't mess around with it. I do realize that people wouldn't want to see the incinerator made exclusive like that though so I gotta come up with some reasoning to have two incinerator rooms even if the reasoning is bullshit :^)

@ghost
Copy link
Author

ghost commented Oct 31, 2014

Conflicts fixed. Please merge this before defibs if possible, this one has a ton of map changes and redoing them is a pain in the ass.

@ghost
Copy link
Author

ghost commented Oct 31, 2014

  • Fixed garbage chute ejecting trash into the AI's transit tube, it now properly shoots stuff into space
  • Tidied up pipe placement
  • Added loot spawner to old incinerator

@ghost
Copy link
Author

ghost commented Nov 2, 2014

@Cheridan @hornygranny @Aranclanos @MrPerson If I have to redo this PR again because of map merge conflicts I will probably kill myself, a decision would be nice regarding this, it's tested

@ghost ghost changed the title Moves incinerator to atmos maint, adds turbine [MAP] Moves incinerator to atmos maint, adds turbine Nov 3, 2014
Cheridan added a commit that referenced this pull request Nov 3, 2014
[MAP] Moves incinerator to atmos maint, adds turbine
@Cheridan Cheridan merged commit 231fa57 into tgstation:master Nov 3, 2014
@ghost ghost deleted the turbine branch January 16, 2015 00:38
tortellinitony pushed a commit to tortellinitony/tgstation that referenced this pull request Dec 22, 2017
…3682

[MIRROR] Makes newscaster feedback messages and comments always a list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants