New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corporate Security aesthetic update #6441
Conversation
Dammit Paprika, I'm already fixing those bugs separately from adding new stuff. |
Read the PR. |
Have you made a thread or asked the community on what their thoughts are? |
Read The PR |
Which poll, link it in the OP. |
Read it again |
The only poll on the feedback forum is the one I made. |
Its awaiting approval since all of paps messages on feedback require that |
Your use of the word overhaul doesn't cover fixing bugs, just changing a lot of the code to have a new system in place. |
Like I said if you bothered to read: My PR just HAPPENS to fix these bugs, if it gets merged before specific bug fix PRs are merged. I changed armor around and stuff and cleared up pre existing bugs with stuff. |
I think gia's comment is more on the misuse of the word overhaul. Revision would probably be a better term. |
This actually makes security look more menacing, but in an a more subtle way than LOOK IM A FACELESS NAZI MONSTER. Not sure if I like it especially, but it's interesting for sure. |
I'd tell you to stop but it wouldn't do anything. |
they're fine, i support it/please revert berets/also please remove the golden gubbins on the hos' trenchcoat |
|
update op? |
As I said on the IRC, I like these changes barring the Warden. (The red sleeved change that is) |
warden is and always will be the fashionista |
hg merge it before steelpoint makes another pr |
As I said. 👍 |
However, nerfing the beret to a low armour rating means officers will just get the helmets out, negating the reason to wear the berets |
i only wear my helmet in case of emergency, and i know a few others like that (owegno?) |
OP will remain oudated likely until this is merged because it's a pain in the butt to play dress up in DM for these pseudo screenshots But basically all I did was trim down the collar on the current kevlar armor, and blend the sleeves of the dress shirt into a red color so that security is more immediately identifiable Thanks to MrPerson for suggesting it. I can't believe I didn't think of it sooner Edit: Before this is merged, I'm going to make the sleeves match the red of the beret a bit closer |
The poll is still around 50/50 either way. I disagree with the changes you've been suddenly making because your moving away from a compromise, of which is meant to be something that both proponents can at least agree to, and back into something you want over me. |
No, people in this PR have expressed they want the grey sleeves instead, so I'm moving towards what the majority of people want, not just you. That's only fair considering your previous PR where you kicked all the work I had done to the curb because of a poll and made no attempt to compromise. |
I'll leave my comments here for the moment. All I'll say is that this PR is turning security's primary colour from red to grey. Sec ain't grey. |
I'll go back to red sleeves if people agree that they looked better than the current grey + badges thing. I just wanted to offer an alternative as people preferred grey sleeves. |
Sec is now grey? |
Up to you guys. People expressed they wanted grey sleeves, so I made them grey again. This is a really easy edit to make, people obviously want these sprites so decide between red and grey sleeves for the dress shirt Edit: let me make some clearer screenshots |
Current sleevs looke like husk overlay with this burnt grey and deep bloody red |
You need to have the armour on to finish the look. Officers will be wearing the armour 95% of the time. Also why does the sleeve fade to white when connecting to the grey? E: Also keep the ausops armour but without the neckline |
It just looks a bit too white when converting, but show us it when wearing armour for the best comparison, I would not mind the changeover if its mostly underneath the armour. |
I'm gonna leave this be for a day and allow people to comment while I work on the poll as well I don't know why it hasn't been approved yet, blame MSO I guess Current topic: Red sleeves or grey sleeves + badges It's a rather simple adjustment to make since it's really only on the officer's suit anyway so fire away |
i like grey better because if you cant recognize a security officer (aka the only people wearing armor, helmets, jackboots, and red sunglasses on the station) youre blind and should probably not be using a computer because you might accidentally break it |
But as I said, those sprites make security predominantly grey and not red. People expect security to be red. Lets see what the forums come up with though. |
People only expect security to be red because security is red right now Just like people used to expect armor to be grey and now it's black, all of this shit will change with time, so that as an argument is really not an issue |
Ultimately it boils down to people's opinion of how the sprites for both sides work, and the fact of the matter is both sides are right in their opinions. It just depends on which side has more support. |
Added old warden's jacket to the back of his locker instead of a plain armor vest so he may wear the red trenchcoat if he desires instead of the navy police coat |
After some discussion i think we've settled on red sleeves as a permanent solution for officers. I removed the 'gradient' fade into the grey part that was kind of noticible when wearing armor. Review pls. |
I can live with the Warden's getup. I approve, besides if that idea we have cooked up in IRC pans out then everyone will be happy forever! |
ok someone merge this now |
Waiving the 24h period on this in the interest of world peace and harmony |
Corporate Security aesthetic update
…stituents #6441 About The Pull Request Same vein (although a lot larger than) #64118 On the tin. This moves them into their own folders and the paths were updated in the code. Why It's Good For The Game It's not exactly good visuals for stuff that can be placed elsewhere to just be sitting in the root. Organization is nice. Changelog cl fix: For those of you into code, some stuff with the icon pathing has been shuffled around so it's no longer in the roots of the icon/ folder. If you aren't into code, that's fine too. /cl
Fixes #6439 #6438 #6431 and all other outstanding bugs with the previously merged PR from steelpoint
This PR isn't meant to primarily fix these metric fuckshit of bugs, but I am saying that it does fix them in any case
Main / Alternate
Officer
Warden
HoS
Based loosely :^) on the sarif guards from the deus ex reboot
Sprite credit to anonymous guy on singulo.
Poll is awaiting approval on the feedback forum but it has been created.