Some icon refactors and old sprite hemmoraging, part 1 of 2 #7127
Conversation
|
Inhand refactor tomorrow. |
| icon_state = "suitjacket_purp" | ||
| item_state = "suitjacket_purp" | ||
| icon_state = "suitjacket_tan" | ||
| item_state = "suitjacket_tan" |
There was a problem hiding this comment.
It's still called a purple suit jacket even though it's apparently tan?
|
Holy shit github, stop being fucking broken. |
|
Is the reasoning for removing the purple lawyer jacket and suit because of it being a Miles Edgeworth reference? I mean the blue lawyer outfit is also a reference to Phoenix Wright's outfit. I can't say that this effects me personally very much considering I never liked how puffy the purple one looked but they were hardly bad sprites. |
|
A lawyer wearing a blue jacket and blue slacks is so much more believable than purple, but it's not necessarily a hard thing to change if we want our lawyers in typical black/tan Blue suits are actually fairly common and I think the look is pretty iconic for our lawyers, whereas purple is just stupid and goofy |
|
On the one hand I do agree that the purple outfit did look a little stupid and goofy but that's just my personal opinion, there's certainly going to be people that disagree with that and who will use this as more ammo against you and against coderbus as well because you know people will jump to the copyright argument. I also don't think it's a good idea to remove something like that in a PR titled merely as refactoring icons, people have certainly accused you of hiding little removals and changes in larger PRs before. I won't accuse you of intentionally trying to do that here but it certainly doesn't seem worth it in my opinion. |
|
Also another thing, in removing the tie that comes with the grey detective suit you can't do the waistcoat look pictured in #6779 because you can't wear multiple accessories on your uniform at once. Just saying, it's a rather nice and iconic detective look to have a waistcoat over a suit with tie, being able to wear multiple accessories at once would be a nice thing to look at maybe. |
|
waistcoats are for waiters, and the bartender's uniform comes with a bowtie for this reason if this really bothers you, add a way to add multiple accessories to a uniform, but it's not my problem because i don't see that as a feature critical to the way the detective functions compared to every dress shirt using the new tie system instead of painted on ties nobody will complain about the miles edgeworth costime being removed, and if they do, nobody here gives a shit anyway and it's blank ammo, essentially being shot to make a lot of noise to scare us or whatever oh no, people who complain about not being able to cosplay a phoenix wright character will leave the server if people shit this PR up the comments will be locked anyway, so don't do that. post on singulo or whatever you have to do to cope, that's what it exists for. |
ghost
changed the title
|
i can't fix the map here, at all, and i can't figure out why i literally downloaded the map from /tg/'s master and it's still saying i have over 6000 line changes gg, the dream is dead |
|
I'll clean these files when the map merger doesn't suck or whatever, inhands first |
ghost
closed this
|
Can't you have different PRs, one fixing the inhand issue, the other removing things you don't like? |
|
that's what this is though, this has nothing to do with inhands but i'll make a new PR without the controversial lawyer changes and just remove old/unwanted shit like the mario and luigi jumpsuits (WE ACTUALLY HAVE THESE) |
|
If I'm reading this correctly, you've pre-emptively dismissed the opinions of people disapproving of the purple suit removal - and informed people that there's nothing they can do, they can just Deal With It. |
|
Anonymousnow you can contribute to the code at any time fuckboy |
|
welp time to close the comments |
ghost
deleted the
* Fixes ghost portal teleportation (tgstation#36438) * Forced teleportation by portals * Update portals.dm * Fixes ghost portal teleportation
I'm not going to refactor clothing in this round, as I think the main issue was a lot of bloat of unused assets. Gun refactoring was 100% necessary though considering energy guns use like 10 icons each to show their charge amount (this should be converted to overlays.)