Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds DrawPixel() + Easels + Canvases! #9073

Merged
merged 3 commits into from
Apr 28, 2015

Conversation

RemieRichards
Copy link
Contributor

Yet more random pixel related stuff.

  • Adds DrawPixel(), and interface for DrawBox() for ease of drawing 1 pixel on an Icon.
  • Adds DrawPixelOn(), an interface for DrawPixel() for ease of drawing 1 pixel on THIS ATOM's icon, and setting it.

Both return the modified icons if they succeeded.

This was made for some form of freeform drawing (Think custom grafitti) But as of yet doing that is literally Pixel Hunting the game as you carefully try to draw your image without fucking up.
It worked, it was just super difficult/annoying for the "artist", Also yes I know that it would totally only be used for griefing/messing around, but that's what grafitti is for.

  • Adds Easels, a holder for canvases
  • Adds Canvases! Draw on these with crayons, clean one pixel with a rag or soap, clean it all off by clicking it with itself (It's a giant etch-a-sketch!) - Sprites by Nienhaus
  • Canvases held in your hand look (to you) like the picture you drew! Amazing!

…awBox(), the latter an Interface for DrawPixel(), They allow drawing of 1 pixel on an icon.
@RemieRichards RemieRichards added the Feature Exposes new bugs in interesting ways label Apr 19, 2015
@Cheridan
Copy link
Contributor

Typically the concern with user-generated content is "what if they draw a dick"

We have the advantage of being /tg/station and hence not giving a damn!

@RemieRichards
Copy link
Contributor Author

True, we'll end up with plenty of dicks, but I kind of hope people also go the route of cableart with it and just draw wild/awesome stuff.

I haven't given up on trying to implement the custom drawing use case for this, just thought while I struggle it'd be nice to commit the procs.

@Iamgoofball
Copy link
Contributor

stop being optimistic

you know that there will be dicks

there will be dicks

@WJohn
Copy link
Contributor

WJohn commented Apr 19, 2015

There aren't a whole lot of cable art dicks or grafitti dicks, I'm not expecting too many once the hype dies down a bit.

@RemieRichards
Copy link
Contributor Author

@WJohn can I get a Canvas+Eisel object sprite? (maybe some inhands if we want it to be picked up and moved) even with the current constraints of pixel hunting, that'd be pretty cool.
Baring in mind that you'd be drawing ON the object sprite, so if you do do it, make the canvas part take up most of the sprite.

@optimumtact
Copy link
Member

the proc name should be dixel()

@RemieRichards RemieRichards changed the title Adds DrawPixel() Adds DrawPixel() + Easels + Canvases! Apr 20, 2015
@RemieRichards
Copy link
Contributor Author

Alright I got sprites from @Nienhaus and have Added Canvases and Easels.

Also while making this I accidentally initialised the global cache twice, leading to a byond warning I'd never seen: "list doubly initialized", which is interesting.

@Cheridan
Copy link
Contributor

Canvases held in your hand look (to you) like the picture you drew! Amazing!

No way to get them to show for other people?

@RemieRichards
Copy link
Contributor Author

@Cheridan Well, I'm not sure about examining them to see it in their hands (Which probably would appear like your drawing)

I could allow you to "attack" someone to show you them with (target << actualbackup) to show them the image, but that seems odd.

@theOperand
Copy link
Contributor

Allow people to frame paintings/pictures and hang them on walls or
something. You could probably make the sprite be a downsized version of the
actual picture, photos do that.

On Tue, Apr 21, 2015 at 10:13 AM, Remie Richards notifications@github.com
wrote:

@Cheridan https://github.com/Cheridan Well, I'm not sure about
examining them to see it in their hands (Which probably would appear
like your drawing)

I could allow you to "attack" someone to show you them with (target <<
actualbackup) to show them the image, but that seems odd.


Reply to this email directly or view it on GitHub
#9073 (comment)
.

@RemieRichards
Copy link
Contributor Author

@Miauw62 there'd be no need to downsize it, As I already stated, this version is still pixelhunty and is manily for the novelty of it.

So if pictures could be hung on walls in this iteration, they'd already show their picture contents.

@CosmicScientist
Copy link
Contributor

Ooo, space art. If you do allow the pictures to be hung on walls in a future iteration, would you also consider allowing them to be saved like literature in the library or would that cause issues similar to the book ordering console or even not be worth it besides the one in one hundred dick drawings that can be appreciated for actually being good?

@RemieRichards
Copy link
Contributor Author

not actually sure if it's easy/practical to export images from byond.
They'd also need a home to sit in and a database to organise them.

@CosmicScientist
Copy link
Contributor

Ah databases, I blissfully forgot they existed. Don't worry about my suggestion then.

@optimumtact
Copy link
Member

It would most likely end up a database of poorly drawn lewd art

@Jordie0608
Copy link
Member

Changelog

@SconesC
Copy link
Contributor

SconesC commented Apr 23, 2015

Will the papers be PDA-scannable?

@RemieRichards
Copy link
Contributor Author

@SconesC say what now?

@Cheridan
Copy link
Contributor

You can hit a paper with your PDA to copy it to your notes.

I don't think these are actually paper, though, so probably not.

@tigercat2000
Copy link
Contributor

If it's possible, I think spraycans should draw a 3x3px box. For fancier drawings, or something.
😐

@RemieRichards
Copy link
Contributor Author

Ideally all crayons (including spraycans) will be able to, on walls and floors (and now canvases), bring up an enlarged version of what they're drawing on, so that you can draw without pixelhunting.

Not in this first PR though, sadly.

@freerealestate
Copy link
Contributor

pretty incredible.

Jordie0608 added a commit that referenced this pull request Apr 28, 2015
Adds DrawPixel() + Easels + Canvases!
@Jordie0608 Jordie0608 merged commit 6bbc274 into tgstation:master Apr 28, 2015
@Crystalwarrior
Copy link

Added a zooming function on Atlas Station codebase, going to PR it soonish. Here's a screenie:
http://puu.sh/i4Sfe/891fb76780.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet