[Review Ready] Positronic Brains! #9147

GunHog · 2015-04-24T14:42:15Z

Shamelessly rips off NTStation/NTstation13#772 by @RemieRichards!

This is a Work In Progress, the following things need to be done before completion:

~~Name and create an appropriate preference and job-ban flag for them, requested by @Ikarrus. I need feedback from admins on this one.~~ I had to put pAI and Posibrain in the same preference, due to the flag being full.
Draft a changelog for Jordie, in my own blood.
Perform extended tests on them, and fix any obvious bugs.
Perform a sample DB test on the admin related changes. Special thanks to SoS for helping me with this!

Positronic Brains (https://tgstation13.org/phpBB/viewtopic.php?f=9&t=3448) are special MMIs that accept ghosts. They are originally a port from Bay, PR'ed to NT by RR, and now yoinked for /tg/ by me!

Notable differences in my version:

New! Borgs created with Xeno brains are now called "Xenoborgs".
Positronic Brains will not have binary or a radio. They will hear and speak only locally.
They are selected in a similar manner as a pAI. A human player picks it up and activates it.
They are informed that they have forgotten their past lives.
They are functionally the same as AIs and Cyborgs. There is only one difference from normal MMIs: They will be named "Android" instead of "Cyborg".
As mech pilots, they cannot be antagonist, and are informed to do no harm. subject to change based on feedback
Cyborgs created during the AI Malfunction gamemode gain Malfunction laws even if they are configured to be unslaved. The same will go for Androids, as they are not meant to be different.

Ban panel changes: Admins, please note:

There are now individual job-ban options for pAI, Drones, and Positronic Brains, "Ghost Roles" category on the job-ban panel.
Deathsquad moved from Antagonist section to "Ghost Roles"; Emergency Response Team are included in Deathsquad bans!

Androids created with Positronic brains:

Empty brain and Android:

-Adds positronic brains - Fixes a runtime in mechs for pilots without DNA

theOperand · 2015-04-24T15:30:47Z

this lets you build huge borg armies unless you make these things very expensive, and i've already heard admins complain about drones being unaccountable griff machines.

RemieRichards · 2015-04-24T16:03:32Z

code/modules/mob/living/carbon/brain/posibrain.dm

+	usr << msg
+	return
+
+/obj/item/device/mmi/posibrain/emp_act(severity)


inherited already. Remove it all.

ike709 · 2015-04-24T18:04:50Z

heil NT
👍

dalmationer · 2015-04-24T21:14:38Z

If you nerds want sprites i totally have some old ones you can use. Check it. http://imgur.com/O20bE6S
There's also some other shit on there like mobile PAIs but whatever. If you want it i can send u guys XCFs or whatevs.

pudl · 2015-04-24T23:09:31Z

that it, /tg/ is dead. rip.

GunHog · 2015-04-25T01:01:19Z

More stuff added, Borgs now can be "Androids", "Cyborgs", or "Xenoborgs"! Added RR!

freerealestate · 2015-04-26T21:44:11Z

Positronic Brains will not have binary or a radio. They will hear and speak only locally.

How come? It'll make it difficult for them to follow their laws, prevent human harm and obey the AI.

GunHog · 2015-04-26T23:16:10Z

How come? It'll make it difficult for them to follow their laws, prevent human harm and obey the AI.

They are MMIs, and are meant to have the same limits as one. They will gain Binary if they are made into an android or AI. Mechs have built in radios, so they will have communication abilities if you make them a pilot. They cannot do anything but talk in brain form, anyway.

freerealestate · 2015-04-26T23:17:28Z

oh, i see

On 27 April 2015 at 11:16, GunHog notifications@github.com wrote:

How come? It'll make it difficult for them to follow their laws, prevent
human harm and obey the AI.

They are MMIs, and are meant to have the same limits as one. They will
gain Binary if they are made into an android or AI. Mechs have built in
radios, so they will have communication abilities if you make them a pilot.
They cannot do anything but talk in brain form, anyway.

Reply to this email directly or view it on GitHub
#9147 (comment)
.

Changes the BE_PAI and "pAI" flag names to "BE_GHOST_ROLE" and "Ghost Roles". Name subject to change.

GunHog · 2015-04-27T16:10:37Z

@Ikarrus, I changed the pAI flag to Ghost Roles, as asked. Basic ban-application testing seems to work. If anyone here does not like the new name, Please supply a better one. I do not really like touching admin related stuff.

Adds a changelog, drawn in blood, and performed according to the rites as scribed in the Unholy One's guide to changelogs. Long may he reign.

PKPenguin321 · 2015-04-27T23:04:08Z

If you're testing for bugs, can you make sure that a cyborg built with a positronic brain can't be deconstructed to yield a human brain? Because once this goes live that'll be one of the first things I'll be testing for, as it could be a way to make ghosts into humans.

GunHog · 2015-04-28T01:09:01Z

That is working normally. Deconned and blown Androids drop their Posibrain as expected. I will hunt for any mistakes.

Ikarrus · 2015-04-28T02:32:15Z

Thanks gunhog

Am I correct in assuming the ban database stores the index instead of the string? So people who were previously pAI jobbanned aren't going to suddenly find themselves unbanned.

GunHog · 2015-04-28T02:37:05Z

Oh.....god....dang it....Ikky, I do not know at all. I have no clue how the database works at all. I will need an admin-coder to comment. If this would unban people, I will revert the name change, and only change appearance on the panel to tell the admin it includes drones and posibrains.

MrStonedOne · 2015-04-28T02:49:24Z

Ok, so the job ban name is used. not an index.

That being said. This is one update query to fix.

UPDATE SS13_bans SET JOB = "Ghost Roles" WHERE JOB = "pAI"

(just make a change log .sql file with that in it and add info the sql change log about the change)

But, a better idea would be to make this a new category in the job ban panel. so we can ban from each 3 things (drones, pai, posbrain) separately, or hit the category button to ban from all 3.

Talk to me on irc if you need help with either of those options.

MrStonedOne · 2015-04-28T03:35:06Z

code/modules/mob/living/simple_animal/friendly/drone/drones_as_items.dm

@@ -16,7 +16,7 @@
 	var/drone_type = /mob/living/simple_animal/drone //Type of drone that will be spawned

 /obj/item/drone_shell/attack_ghost(mob/user)
-	if(jobban_isbanned(user,"pAI"))
+	if(jobban_isbanned(user,"Ghost Roles"))


replace this with drone.

Dorsisdwarf · 2015-04-28T12:19:28Z

I don't see why we'd need the ability to ban individual ghost roles.

As far as I'm concerned, someone who's being a shitlord/metagamer as a drone is going to be the same as a pAI, and definitely a posibrain. Even if they aren't, bans are applied across the type of job. Beat a prisoner to death for fun as a warden and you get a sec jobban, not a warden jobban

- Deathsquad moved from Antagonist to Ghost Roles. - pAI jobbans split into drone, pAI, and posibrains. - Posibrains back under pAI preference flag (the byte is full) - Fixed Posibrain sprite if it fails to get a ghost.

GunHog · 2015-04-28T19:52:41Z

I don't see why we'd need the ability to ban individual ghost roles.

As far as I'm concerned, someone who's being a shitlord/metagamer as a drone is going to be the same as a pAI, and definitely a posibrain. Even if they aren't, bans are applied across the type of job. Beat a prisoner to death for fun as a warden and you get a sec jobban, not a warden jobban

You can now do both. If you want to jobban someone from all ghost roles, you may do so, but some admins might think differently. I am giving them both choices, because admins need the power!

Commit comments:
I moved Deaf Squids to ghost roles, per MSO's request.
I split the job-bans for drone, pAI, and Posibrains.
The stupid byteflag is full, so I had to shove pAI and Posibrains back together in preferences.

PLEASE LET THIS BE THE LAST I HAVE TO MESS WITH ADMIN STUFF. It is scary, and I do not want admins angry with me!

GunHog · 2015-05-03T01:24:29Z

I cannot find anything wrong with it now, ready for maintainer review!

[Review Ready] Positronic Brains!

Positronic Brains!

aa59485

-Adds positronic brains - Fixes a runtime in mechs for pilots without DNA

RemieRichards reviewed Apr 24, 2015
View reviewed changes

RemieRichards added the Feature Exposes new bugs in interesting ways label Apr 24, 2015

Tweaks and changes!

1f6af46

pAI -> Ghost Roles

ae1ad22

Changes the BE_PAI and "pAI" flag names to "BE_GHOST_ROLE" and "Ghost Roles". Name subject to change.

Changelog

7fee837

Adds a changelog, drawn in blood, and performed according to the rites as scribed in the Unholy One's guide to changelogs. Long may he reign.

GunHog changed the title ~~[WIP] Positronic Brains!~~ [Testing] Positronic Brains! Apr 27, 2015

MrStonedOne reviewed Apr 28, 2015
View reviewed changes

Ban panel and preferences changes

00a6762

- Deathsquad moved from Antagonist to Ghost Roles. - pAI jobbans split into drone, pAI, and posibrains. - Posibrains back under pAI preference flag (the byte is full) - Fixed Posibrain sprite if it fails to get a ghost.

GunHog changed the title ~~[Testing] Positronic Brains!~~ [WIP] Positronic Brains! Apr 28, 2015

GunHog changed the title ~~[WIP] Positronic Brains!~~ [Testing] Positronic Brains! May 1, 2015

GunHog changed the title ~~[Testing] Positronic Brains!~~ [Review Ready] Positronic Brains! May 3, 2015

RemieRichards added a commit that referenced this pull request May 3, 2015

Merge pull request #9147 from GunHog/Rise_Of_The_RR_Androids

e5f034f

[Review Ready] Positronic Brains!

RemieRichards merged commit e5f034f into tgstation:master May 3, 2015

GunHog deleted the Rise_Of_The_RR_Androids branch May 12, 2015 23:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Review Ready] Positronic Brains! #9147

[Review Ready] Positronic Brains! #9147

GunHog commented Apr 24, 2015

theOperand commented Apr 24, 2015

RemieRichards Apr 24, 2015

ike709 commented Apr 24, 2015

dalmationer commented Apr 24, 2015

pudl commented Apr 24, 2015

GunHog commented Apr 25, 2015

freerealestate commented Apr 26, 2015

GunHog commented Apr 26, 2015

freerealestate commented Apr 26, 2015

GunHog commented Apr 27, 2015

PKPenguin321 commented Apr 27, 2015

GunHog commented Apr 28, 2015

Ikarrus commented Apr 28, 2015

GunHog commented Apr 28, 2015

MrStonedOne commented Apr 28, 2015

MrStonedOne Apr 28, 2015

Dorsisdwarf commented Apr 28, 2015

GunHog commented Apr 28, 2015

GunHog commented May 3, 2015

[Review Ready] Positronic Brains! #9147

[Review Ready] Positronic Brains! #9147

Conversation

GunHog commented Apr 24, 2015

theOperand commented Apr 24, 2015

RemieRichards Apr 24, 2015

Choose a reason for hiding this comment

ike709 commented Apr 24, 2015

dalmationer commented Apr 24, 2015

pudl commented Apr 24, 2015

GunHog commented Apr 25, 2015

freerealestate commented Apr 26, 2015

GunHog commented Apr 26, 2015

freerealestate commented Apr 26, 2015

GunHog commented Apr 27, 2015

PKPenguin321 commented Apr 27, 2015

GunHog commented Apr 28, 2015

Ikarrus commented Apr 28, 2015

GunHog commented Apr 28, 2015

MrStonedOne commented Apr 28, 2015

MrStonedOne Apr 28, 2015

Choose a reason for hiding this comment

Dorsisdwarf commented Apr 28, 2015

GunHog commented Apr 28, 2015

GunHog commented May 3, 2015