Peacekeeper Cyborg Cookie synthesizer doesn't store cookie

[Mooshimi]

Round ID: Irrelevant

Reproduction:

Be a peacekeeper cyborg and periodically examine your cookie synthesizer to check stock, and notice it's always at 0, and you have to wait 10 seconds after printing a cookie to print another.

[haukeschuemann]

tgstation/code/game/objects/items/RSF.dm

Lines 166 to 170 in aa034d0

	discriptor = "cookie-units"
	action_type = "Fabricates"
	cooldowndelay = 10 SECONDS
	///Tracks whether or not the cookiesynth is about to print a poisoned cookie
	var/toxin = FALSE //This might be better suited to some initialize fuckery, but I don't have a good "poisoned" sprite

Code implies this is intentional.

[haukeschuemann]

#57786

balance: Cyborg cookie dispensers can now only dispense a cookie once every 10 seconds (instead of once per second). Non-cyborg cookie dispensers no longer self-recharge, but can now accept compressed matter cartirdges for reloading purposes. Support has been added for other types of RSFs to have use cooldowns.

Is the issue that the borg cookie printer does not automatically recharge? If so, I didn't catch that from the issue body.

[Mooshimi]

to_chat(user, span_notice("\The [src] now holds [matter]/[max_matter] [discriptor]."))
this line suggests that there should be a built up stock of them, no??

[Mooshimi]

it shows 0/10 on the examine text

[moocowswag]

So either the examine text is a bug or the functionality is a bug.

[timothymtorres]

More relevant code:

tgstation/code/game/objects/items/RSF.dm

Lines 58 to 60 in aa034d0

	/obj/item/rsf/examine(mob/user)
	. = ..()
	. += span_notice("It currently holds [matter]/[max_matter] [discriptor].")

tgstation/code/game/objects/items/RSF.dm

Lines 130 to 148 in aa034d0

	///A helper proc. checks to see if we can afford the amount of charge that is passed, and if we can docs the charge from our base, and returns TRUE. If we can't we return FALSE
	/obj/item/rsf/proc/use_matter(charge, mob/user)
	if(iscyborg(user))
	var/mob/living/silicon/robot/R = user
	var/end_charge = R.cell.charge - charge
	if(end_charge < 0)
	to_chat(user, span_warning("You do not have enough power to use [src]."))
	icon_state = spent_icon_state
	return FALSE
	R.cell.charge = end_charge
	return TRUE
	else
	if(matter - 1 < 0)
	to_chat(user, span_warning("\The [src] doesn't have enough [discriptor] left."))
	icon_state = spent_icon_state
	return FALSE
	matter--
	to_chat(user, span_notice("\The [src] now holds [matter]/[max_matter] [discriptor]."))
	return TRUE

[Mooshimi]

The mediborgs's candy thing with how it stores candies made me think this would work the same way, with the examine text supporting the idea.