Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mining cyborg's mining scanner turns off on unequip #81207

Closed
honkpocket opened this issue Jan 31, 2024 · 6 comments · Fixed by #81604
Closed

Mining cyborg's mining scanner turns off on unequip #81207

honkpocket opened this issue Jan 31, 2024 · 6 comments · Fixed by #81604
Labels
Consistency Issue The dev team didn't think of everything

Comments

@honkpocket
Copy link
Contributor

honkpocket commented Jan 31, 2024

Untitled.video.-.Made.with.Clipchamp.3.mp4

Code_3En3Z7x4fq

code\game\objects\items\devices\scanners\t_scanner.dm

@dragomagol
Copy link
Member

Not a bug, that's the functionality of the module,

@honkpocket
Copy link
Contributor Author

honkpocket commented Jan 31, 2024

Not a bug, that's the functionality of the module,

The code snippet in the PR is loading for you, right?

The current way to play mining cyborg is to not touch the scanner when you spawn in, so it stays on without being in your active hotbar. Uniquely for cyborgs it has code to always spawn enabled, and to always be enabled even when unequipped. Part of this code is nonfunctional, and its highlighted in this issue. It is a bug.

@dragomagol
Copy link
Member

Oh I see, it spawns in enabled. It turning off when it goes back into your storage makes sense to me (I think welders do this too?) but it should definitely be one way or the other

@dragomagol dragomagol added the Consistency Issue The dev team didn't think of everything label Jan 31, 2024
@honkpocket
Copy link
Contributor Author

Code_3En3Z7x4fq
Code_UmI0DHsevM
This isn't a consistency issue, its clear this thing is supposed to be always on for cyborgs. Read #78524. Its totally unintended, quote This module allows for the same ability to discover, but this is not the case currently.

If cyborgs are supposed to keep 1 slot reserved to scan for minerals, that should have been added to the changelog, because its an extremely significant nerf.

@dragomagol
Copy link
Member

@ArcaneMusic

@Kitfox88
Copy link

Still happening, still irritating as hell to waste a module slot on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Consistency Issue The dev team didn't think of everything
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants