v3 Android build failure RN 0.59

[geraintwhite]

Since v3 I am getting a build failure on Android using RN 0.59.

It looks like LayoutShadowNode.onBeforeLayout was changed in RN 0.60 from taking no arguments to taking one argument.

This module started using LayoutShadowNode.onBeforeLayout as of #85.

> Task :react-native-safe-area-context:compileDebugJavaWithJavac FAILED
/Users/geraintwhite/repos/work/newteam/cloud-voice-app/node_modules/react-native-safe-area-context/android/src/main/java/com/th3rdwave/safeareacontext/SafeAreaViewShadowNode.java:126: error: method does not override or implement a method from a supertype
  @Override
  ^
/Users/geraintwhite/repos/work/newteam/cloud-voice-app/node_modules/react-native-safe-area-context/android/src/main/java/com/th3rdwave/safeareacontext/SafeAreaViewShadowNode.java:133: error: method onBeforeLayout in class ReactShadowNodeImpl cannot be applied to given types;
    super.onBeforeLayout(nativeViewHierarchyOptimizer);
         ^
  required: no arguments
  found: NativeViewHierarchyOptimizer
  reason: actual and formal argument lists differ in length
2 errors

[janicduplessis]

Thanks for reporting this, I’ll see if there is a way to make it backwards compatible, but if not I’ll update the readme to mention 3.0 requires rn 0.60+.

[janicduplessis]

cc @jacobp100

[jacobp100]

So I know wix does this by having a 0.59 and 0.60 folder. https://github.com/wix/react-native-notifications/tree/master/android/app/src . I don’t know how it’s all linked together, and it might be more hassle than it’s worth

[janicduplessis]

@grit96 I think I found a working solution, can you try 3.0.3 to see if it fixes the issue?

[geraintwhite]

Thanks @janicduplessis, 3.0.3 seems to work well.