Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make intron coords consistently [1-based) the same way start/end are #32

Closed
thackl opened this issue Feb 2, 2021 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@thackl
Copy link
Owner

thackl commented Feb 2, 2021

sha-1bfbdfe

f0 <- tibble(
  seq_id="a",
  start=1,
  end = 3,
  introns=list(c(2,2)),
  )
gggenomes(genes=f0) +
  geom_gene(position="pile") + theme_bw()

Currently produces a 0-length intron between 2 and 3. Should, however produce a 1bp intron covering pos 2.

@thackl thackl added the bug Something isn't working label Feb 2, 2021
@thackl
Copy link
Owner Author

thackl commented Feb 2, 2021

Fixed in ef25576

image

f0 <- tibble(
  seq_id="a",
  start=1,
  end = 3,
  strand = c("+", "-"),
  geom_id = c("a1", "a2"),
  type = "CDS",
  introns=list(c(2,2)),
  )

g0 <- read_gff3("data-raw/foo.gff")

gggenomes(genes=bind_rows(f0, g0)) +
  geom_gene(position="pile") + theme_bw()

@thackl thackl self-assigned this Feb 7, 2021
@thackl thackl closed this as completed in ef25576 Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant