Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put log--detailed back #47

Closed
schwern opened this issue Apr 1, 2013 · 7 comments
Closed

Put log--detailed back #47

schwern opened this issue Apr 1, 2013 · 7 comments

Comments

@schwern
Copy link
Collaborator

schwern commented Apr 1, 2013

The new pinto log only displays the revision, date, author and message. There doesn't appear to be any way to see what's actually changed. The --detailed flag used to provide this critical functionality.

Could we have it back?

@thaljef
Copy link
Owner

thaljef commented Apr 1, 2013

Yeah, this feature fell out when I redesigned the version-control subsystem. But I understand its importance.

Computing the difference between revisions is somewhat expensive now. And most of the time, you probably only care about certain revisions. So showing the diff for every revision in the log seems like overkill.

My plan is to extend the diff command to accept revisions numbers and possibly some kind of ref-spec similar to Git. Once you know which revisions you are interested in, you could see the difference like this:

$ pinto diff 3465afbe f3876ade

What do you think of that?

@schwern
Copy link
Collaborator Author

schwern commented Apr 1, 2013

The ability to search the changes is very important. Often I'm searching through the log to see when I upgraded or downgraded a given distribution, so I don't already know the revision numbers.

@thaljef
Copy link
Owner

thaljef commented Apr 1, 2013

Understood. We'll just have to see how expensive it is. I've added this to
the todo list.

@schwern
Copy link
Collaborator Author

schwern commented Apr 2, 2013

An extra data point about my use of Pinto. My automated import of modules had a message like "Matching existing installed rpm version" with no mention of what was being added. I figured that was easy to get what was being added from the pinto log.

@thaljef
Copy link
Owner

thaljef commented Apr 2, 2013

Makes perfect sense.

@thaljef
Copy link
Owner

thaljef commented Jan 10, 2014

Pinto 0.097_01 will ship to CPAN as soon as PAUSE is running again. Note this is a developer version for now.

The log command now has a --with-diffs option (or -d for short) that displays a diff with each revision.

There have been several other enhancements to diff reporting throughout Pinto. See the Changes log for details.

@thaljef
Copy link
Owner

thaljef commented Feb 1, 2014

Pinto 0.098 has shipped to CPAN with this feature, so I'm closing this issue out.

@thaljef thaljef closed this as completed Feb 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants