Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylistic changes & const expression for MULTIPLIER table #2

Merged
merged 5 commits into from Apr 23, 2023

Conversation

mitiko
Copy link
Contributor

@mitiko mitiko commented Apr 23, 2023

Hi, awesome project, I'd love to contribute more (for example adding a more accurate arithmetic coder).
I updated some profile settings, the results aren't significantly better on my machine, and likely due to alignment changes:

Before:
1000000000 -> 236319404 (23.63%) in 23.09 seconds (41.30 MiB/s)
236319404 -> 1000000000 (23.63%) in 56.22 seconds (16.96 MiB/s)
sha256sum: f1657ca6d34b111b524d76a4fa257f1f3f1eb1616cca967189ea7ef64ef329c1  enwik9.out

After:
1000000000 -> 236319404 (23.63%) in 22.91 seconds (41.63 MiB/s)
236319404 -> 1000000000 (23.63%) in 55.40 seconds (17.21 MiB/s)
sha256sum: f1657ca6d34b111b524d76a4fa257f1f3f1eb1616cca967189ea7ef64ef329c1  enwik9.out

I don't want to be rude about any style guide, so I just ran cargo fmt :))
Also, cool to see rounding on that table, did you generate it with python?
Feel free, to edit anything, or request some changes!

@thanhminhmr
Copy link
Owner

thanhminhmr commented Apr 23, 2023

Hi, awesome project, I'd love to contribute more (for example adding a more accurate arithmetic coder).

Keep them coming, I'd love to see that!

I don't want to be rude about any style guide, so I just ran cargo fmt :))

Good change! My style guide currently is the result of the "Format code" in Intellij with Rust plugin, and I didn't know that cargo fmt is a thing!

Also, cool to see rounding on that table, did you generate it with python?

I actually wrote a small Rust program to generate and print them out.

@thanhminhmr thanhminhmr merged commit 517f865 into thanhminhmr:main Apr 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants