-
Notifications
You must be signed in to change notification settings - Fork 2k
/
compact_e2e_test.go
525 lines (449 loc) · 19.1 KB
/
compact_e2e_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
// Copyright (c) The Thanos Authors.
// Licensed under the Apache License 2.0.
package compact
import (
"bytes"
"context"
"encoding/json"
"fmt"
"io/ioutil"
"os"
"path"
"path/filepath"
"sort"
"testing"
"time"
"github.com/go-kit/kit/log"
"github.com/oklog/ulid"
"github.com/prometheus/client_golang/prometheus"
"github.com/prometheus/client_golang/prometheus/promauto"
promtest "github.com/prometheus/client_golang/prometheus/testutil"
"github.com/prometheus/prometheus/pkg/labels"
"github.com/prometheus/prometheus/tsdb"
"github.com/thanos-io/thanos/pkg/block"
"github.com/thanos-io/thanos/pkg/block/metadata"
"github.com/thanos-io/thanos/pkg/objstore"
"github.com/thanos-io/thanos/pkg/objstore/objtesting"
"github.com/thanos-io/thanos/pkg/testutil"
"github.com/thanos-io/thanos/pkg/testutil/e2eutil"
)
func TestSyncer_GarbageCollect_e2e(t *testing.T) {
objtesting.ForeachStore(t, func(t *testing.T, bkt objstore.Bucket) {
ctx, cancel := context.WithTimeout(context.Background(), 120*time.Second)
defer cancel()
// Generate 10 source block metas and construct higher level blocks
// that are higher compactions of them.
var metas []*metadata.Meta
var ids []ulid.ULID
for i := 0; i < 10; i++ {
var m metadata.Meta
m.Version = 1
m.ULID = ulid.MustNew(uint64(i), nil)
m.Compaction.Sources = []ulid.ULID{m.ULID}
m.Compaction.Level = 1
ids = append(ids, m.ULID)
metas = append(metas, &m)
}
var m1 metadata.Meta
m1.Version = 1
m1.ULID = ulid.MustNew(100, nil)
m1.Compaction.Level = 2
m1.Compaction.Sources = ids[:4]
m1.Thanos.Downsample.Resolution = 0
var m2 metadata.Meta
m2.Version = 1
m2.ULID = ulid.MustNew(200, nil)
m2.Compaction.Level = 2
m2.Compaction.Sources = ids[4:8] // last two source IDs is not part of a level 2 block.
m2.Thanos.Downsample.Resolution = 0
var m3 metadata.Meta
m3.Version = 1
m3.ULID = ulid.MustNew(300, nil)
m3.Compaction.Level = 3
m3.Compaction.Sources = ids[:9] // last source ID is not part of level 3 block.
m3.Thanos.Downsample.Resolution = 0
var m4 metadata.Meta
m4.Version = 1
m4.ULID = ulid.MustNew(400, nil)
m4.Compaction.Level = 2
m4.Compaction.Sources = ids[9:] // covers the last block but is a different resolution. Must not trigger deletion.
m4.Thanos.Downsample.Resolution = 1000
// Create all blocks in the bucket.
for _, m := range append(metas, &m1, &m2, &m3, &m4) {
fmt.Println("create", m.ULID)
var buf bytes.Buffer
testutil.Ok(t, json.NewEncoder(&buf).Encode(&m))
testutil.Ok(t, bkt.Upload(ctx, path.Join(m.ULID.String(), metadata.MetaFilename), &buf))
}
duplicateBlocksFilter := block.NewDeduplicateFilter()
metaFetcher, err := block.NewMetaFetcher(nil, 32, objstore.WithNoopInstr(bkt), "", nil, []block.MetadataFilter{
duplicateBlocksFilter,
}, nil)
testutil.Ok(t, err)
blocksMarkedForDeletion := promauto.With(nil).NewCounter(prometheus.CounterOpts{})
garbageCollectedBlocks := promauto.With(nil).NewCounter(prometheus.CounterOpts{})
ignoreDeletionMarkFilter := block.NewIgnoreDeletionMarkFilter(nil, nil, 48*time.Hour)
sy, err := NewSyncer(nil, nil, bkt, metaFetcher, duplicateBlocksFilter, ignoreDeletionMarkFilter, blocksMarkedForDeletion, garbageCollectedBlocks, 1)
testutil.Ok(t, err)
// Do one initial synchronization with the bucket.
testutil.Ok(t, sy.SyncMetas(ctx))
testutil.Ok(t, sy.GarbageCollect(ctx))
var rem []ulid.ULID
err = bkt.Iter(ctx, "", func(n string) error {
id := ulid.MustParse(n[:len(n)-1])
deletionMarkFile := path.Join(id.String(), metadata.DeletionMarkFilename)
exists, err := bkt.Exists(ctx, deletionMarkFile)
if err != nil {
return err
}
if !exists {
rem = append(rem, id)
}
return nil
})
testutil.Ok(t, err)
sort.Slice(rem, func(i, j int) bool {
return rem[i].Compare(rem[j]) < 0
})
// Only the level 3 block, the last source block in both resolutions should be left.
testutil.Equals(t, []ulid.ULID{metas[9].ULID, m3.ULID, m4.ULID}, rem)
// After another sync the changes should also be reflected in the local groups.
testutil.Ok(t, sy.SyncMetas(ctx))
testutil.Ok(t, sy.GarbageCollect(ctx))
// Only the level 3 block, the last source block in both resolutions should be left.
grouper := NewDefaultGrouper(nil, bkt, false, false, nil, blocksMarkedForDeletion, garbageCollectedBlocks)
groups, err := grouper.Groups(sy.Metas())
testutil.Ok(t, err)
testutil.Equals(t, "0@17241709254077376921", groups[0].Key())
testutil.Equals(t, []ulid.ULID{metas[9].ULID, m3.ULID}, groups[0].IDs())
testutil.Equals(t, "1000@17241709254077376921", groups[1].Key())
testutil.Equals(t, []ulid.ULID{m4.ULID}, groups[1].IDs())
})
}
func MetricCount(c prometheus.Collector) int {
var (
mCount int
mChan = make(chan prometheus.Metric)
done = make(chan struct{})
)
go func() {
for range mChan {
mCount++
}
close(done)
}()
c.Collect(mChan)
close(mChan)
<-done
return mCount
}
func TestGroup_Compact_e2e(t *testing.T) {
objtesting.ForeachStore(t, func(t *testing.T, bkt objstore.Bucket) {
ctx, cancel := context.WithTimeout(context.Background(), 120*time.Second)
defer cancel()
// Create fresh, empty directory for actual test.
dir, err := ioutil.TempDir("", "test-compact")
testutil.Ok(t, err)
defer func() { testutil.Ok(t, os.RemoveAll(dir)) }()
logger := log.NewLogfmtLogger(os.Stderr)
reg := prometheus.NewRegistry()
ignoreDeletionMarkFilter := block.NewIgnoreDeletionMarkFilter(logger, objstore.WithNoopInstr(bkt), 48*time.Hour)
duplicateBlocksFilter := block.NewDeduplicateFilter()
metaFetcher, err := block.NewMetaFetcher(nil, 32, objstore.WithNoopInstr(bkt), "", nil, []block.MetadataFilter{
ignoreDeletionMarkFilter,
duplicateBlocksFilter,
}, nil)
testutil.Ok(t, err)
blocksMarkedForDeletion := promauto.With(nil).NewCounter(prometheus.CounterOpts{})
garbageCollectedBlocks := promauto.With(nil).NewCounter(prometheus.CounterOpts{})
sy, err := NewSyncer(nil, nil, bkt, metaFetcher, duplicateBlocksFilter, ignoreDeletionMarkFilter, blocksMarkedForDeletion, garbageCollectedBlocks, 5)
testutil.Ok(t, err)
comp, err := tsdb.NewLeveledCompactor(ctx, reg, logger, []int64{1000, 3000}, nil)
testutil.Ok(t, err)
grouper := NewDefaultGrouper(logger, bkt, false, false, reg, blocksMarkedForDeletion, garbageCollectedBlocks)
bComp, err := NewBucketCompactor(logger, sy, grouper, comp, dir, bkt, 2)
testutil.Ok(t, err)
// Compaction on empty should not fail.
testutil.Ok(t, bComp.Compact(ctx))
testutil.Equals(t, 0.0, promtest.ToFloat64(sy.metrics.garbageCollectedBlocks))
testutil.Equals(t, 0.0, promtest.ToFloat64(sy.metrics.blocksMarkedForDeletion))
testutil.Equals(t, 0.0, promtest.ToFloat64(sy.metrics.garbageCollectionFailures))
testutil.Equals(t, 0, MetricCount(grouper.compactions))
testutil.Equals(t, 0, MetricCount(grouper.compactionRunsStarted))
testutil.Equals(t, 0, MetricCount(grouper.compactionRunsCompleted))
testutil.Equals(t, 0, MetricCount(grouper.compactionFailures))
_, err = os.Stat(dir)
testutil.Assert(t, os.IsNotExist(err), "dir %s should be remove after compaction.", dir)
// Test label name with slash, regression: https://github.com/thanos-io/thanos/issues/1661.
extLabels := labels.Labels{{Name: "e1", Value: "1/weird"}}
extLabels2 := labels.Labels{{Name: "e1", Value: "1"}}
metas := createAndUpload(t, bkt, []blockgenSpec{
{
numSamples: 100, mint: 0, maxt: 1000, extLset: extLabels, res: 124,
series: []labels.Labels{
{{Name: "a", Value: "1"}},
{{Name: "a", Value: "2"}, {Name: "b", Value: "2"}},
{{Name: "a", Value: "3"}},
{{Name: "a", Value: "4"}},
},
},
{
numSamples: 100, mint: 2000, maxt: 3000, extLset: extLabels, res: 124,
series: []labels.Labels{
{{Name: "a", Value: "3"}},
{{Name: "a", Value: "4"}},
{{Name: "a", Value: "5"}},
{{Name: "a", Value: "6"}},
},
},
// Mix order to make sure compact is able to deduct min time / max time.
// Currently TSDB does not produces empty blocks (see: https://github.com/prometheus/tsdb/pull/374). However before v2.7.0 it was
// so we still want to mimick this case as close as possible.
{
mint: 1000, maxt: 2000, extLset: extLabels, res: 124,
// Empty block.
},
// Due to TSDB compaction delay (not compacting fresh block), we need one more block to be pushed to trigger compaction.
{
numSamples: 100, mint: 3000, maxt: 4000, extLset: extLabels, res: 124,
series: []labels.Labels{
{{Name: "a", Value: "7"}},
},
},
// Extra block for "distraction" for different resolution and one for different labels.
{
numSamples: 100, mint: 5000, maxt: 6000, extLset: labels.Labels{{Name: "e1", Value: "2"}}, res: 124,
series: []labels.Labels{
{{Name: "a", Value: "7"}},
},
},
// Extra block for "distraction" for different resolution and one for different labels.
{
numSamples: 100, mint: 4000, maxt: 5000, extLset: extLabels, res: 0,
series: []labels.Labels{
{{Name: "a", Value: "7"}},
},
},
// Second group (extLabels2).
{
numSamples: 100, mint: 2000, maxt: 3000, extLset: extLabels2, res: 124,
series: []labels.Labels{
{{Name: "a", Value: "3"}},
{{Name: "a", Value: "4"}},
{{Name: "a", Value: "6"}},
},
},
{
numSamples: 100, mint: 0, maxt: 1000, extLset: extLabels2, res: 124,
series: []labels.Labels{
{{Name: "a", Value: "1"}},
{{Name: "a", Value: "2"}, {Name: "b", Value: "2"}},
{{Name: "a", Value: "3"}},
{{Name: "a", Value: "4"}},
},
},
// Due to TSDB compaction delay (not compacting fresh block), we need one more block to be pushed to trigger compaction.
{
numSamples: 100, mint: 3000, maxt: 4000, extLset: extLabels2, res: 124,
series: []labels.Labels{
{{Name: "a", Value: "7"}},
},
},
})
testutil.Ok(t, bComp.Compact(ctx))
testutil.Equals(t, 5.0, promtest.ToFloat64(sy.metrics.garbageCollectedBlocks))
testutil.Equals(t, 5.0, promtest.ToFloat64(sy.metrics.blocksMarkedForDeletion))
testutil.Equals(t, 0.0, promtest.ToFloat64(sy.metrics.garbageCollectionFailures))
testutil.Equals(t, 4, MetricCount(grouper.compactions))
testutil.Equals(t, 1.0, promtest.ToFloat64(grouper.compactions.WithLabelValues(DefaultGroupKey(metas[0].Thanos))))
testutil.Equals(t, 1.0, promtest.ToFloat64(grouper.compactions.WithLabelValues(DefaultGroupKey(metas[7].Thanos))))
testutil.Equals(t, 0.0, promtest.ToFloat64(grouper.compactions.WithLabelValues(DefaultGroupKey(metas[4].Thanos))))
testutil.Equals(t, 0.0, promtest.ToFloat64(grouper.compactions.WithLabelValues(DefaultGroupKey(metas[5].Thanos))))
testutil.Equals(t, 4, MetricCount(grouper.compactionRunsStarted))
testutil.Equals(t, 2.0, promtest.ToFloat64(grouper.compactionRunsStarted.WithLabelValues(DefaultGroupKey(metas[0].Thanos))))
testutil.Equals(t, 2.0, promtest.ToFloat64(grouper.compactionRunsStarted.WithLabelValues(DefaultGroupKey(metas[7].Thanos))))
// TODO(bwplotka): Looks like we do some unnecessary loops. Not a major problem but investigate.
testutil.Equals(t, 2.0, promtest.ToFloat64(grouper.compactionRunsStarted.WithLabelValues(DefaultGroupKey(metas[4].Thanos))))
testutil.Equals(t, 2.0, promtest.ToFloat64(grouper.compactionRunsStarted.WithLabelValues(DefaultGroupKey(metas[5].Thanos))))
testutil.Equals(t, 4, MetricCount(grouper.compactionRunsCompleted))
testutil.Equals(t, 2.0, promtest.ToFloat64(grouper.compactionRunsCompleted.WithLabelValues(DefaultGroupKey(metas[0].Thanos))))
testutil.Equals(t, 2.0, promtest.ToFloat64(grouper.compactionRunsCompleted.WithLabelValues(DefaultGroupKey(metas[7].Thanos))))
// TODO(bwplotka): Looks like we do some unnecessary loops. Not a major problem but investigate.
testutil.Equals(t, 2.0, promtest.ToFloat64(grouper.compactionRunsCompleted.WithLabelValues(DefaultGroupKey(metas[4].Thanos))))
testutil.Equals(t, 2.0, promtest.ToFloat64(grouper.compactionRunsCompleted.WithLabelValues(DefaultGroupKey(metas[5].Thanos))))
testutil.Equals(t, 4, MetricCount(grouper.compactionFailures))
testutil.Equals(t, 0.0, promtest.ToFloat64(grouper.compactionFailures.WithLabelValues(DefaultGroupKey(metas[0].Thanos))))
testutil.Equals(t, 0.0, promtest.ToFloat64(grouper.compactionFailures.WithLabelValues(DefaultGroupKey(metas[7].Thanos))))
testutil.Equals(t, 0.0, promtest.ToFloat64(grouper.compactionFailures.WithLabelValues(DefaultGroupKey(metas[4].Thanos))))
testutil.Equals(t, 0.0, promtest.ToFloat64(grouper.compactionFailures.WithLabelValues(DefaultGroupKey(metas[5].Thanos))))
_, err = os.Stat(dir)
testutil.Assert(t, os.IsNotExist(err), "dir %s should be remove after compaction.", dir)
// Check object storage. All blocks that were included in new compacted one should be removed. New compacted ones
// are present and looks as expected.
nonCompactedExpected := map[ulid.ULID]bool{
metas[3].ULID: false,
metas[4].ULID: false,
metas[5].ULID: false,
metas[8].ULID: false,
}
others := map[string]metadata.Meta{}
testutil.Ok(t, bkt.Iter(ctx, "", func(n string) error {
id, ok := block.IsBlockDir(n)
if !ok {
return nil
}
if _, ok := nonCompactedExpected[id]; ok {
nonCompactedExpected[id] = true
return nil
}
meta, err := block.DownloadMeta(ctx, logger, bkt, id)
if err != nil {
return err
}
others[DefaultGroupKey(meta.Thanos)] = meta
return nil
}))
for id, found := range nonCompactedExpected {
testutil.Assert(t, found, "not found expected block %s", id.String())
}
// We expect two compacted blocks only outside of what we expected in `nonCompactedExpected`.
testutil.Equals(t, 2, len(others))
{
meta, ok := others[defaultGroupKey(124, extLabels)]
testutil.Assert(t, ok, "meta not found")
testutil.Equals(t, int64(0), meta.MinTime)
testutil.Equals(t, int64(3000), meta.MaxTime)
testutil.Equals(t, uint64(6), meta.Stats.NumSeries)
testutil.Equals(t, uint64(2*4*100), meta.Stats.NumSamples) // Only 2 times 4*100 because one block was empty.
testutil.Equals(t, 2, meta.Compaction.Level)
testutil.Equals(t, []ulid.ULID{metas[0].ULID, metas[1].ULID, metas[2].ULID}, meta.Compaction.Sources)
// Check thanos meta.
testutil.Assert(t, labels.Equal(extLabels, labels.FromMap(meta.Thanos.Labels)), "ext labels does not match")
testutil.Equals(t, int64(124), meta.Thanos.Downsample.Resolution)
testutil.Assert(t, len(meta.Thanos.SegmentFiles) > 0, "compacted blocks have segment files set")
}
{
meta, ok := others[defaultGroupKey(124, extLabels2)]
testutil.Assert(t, ok, "meta not found")
testutil.Equals(t, int64(0), meta.MinTime)
testutil.Equals(t, int64(3000), meta.MaxTime)
testutil.Equals(t, uint64(5), meta.Stats.NumSeries)
testutil.Equals(t, uint64(2*4*100-100), meta.Stats.NumSamples)
testutil.Equals(t, 2, meta.Compaction.Level)
testutil.Equals(t, []ulid.ULID{metas[6].ULID, metas[7].ULID}, meta.Compaction.Sources)
// Check thanos meta.
testutil.Assert(t, labels.Equal(extLabels2, labels.FromMap(meta.Thanos.Labels)), "ext labels does not match")
testutil.Equals(t, int64(124), meta.Thanos.Downsample.Resolution)
testutil.Assert(t, len(meta.Thanos.SegmentFiles) > 0, "compacted blocks have segment files set")
}
})
}
type blockgenSpec struct {
mint, maxt int64
series []labels.Labels
numSamples int
extLset labels.Labels
res int64
}
func createAndUpload(t testing.TB, bkt objstore.Bucket, blocks []blockgenSpec) (metas []*metadata.Meta) {
prepareDir, err := ioutil.TempDir("", "test-compact-prepare")
testutil.Ok(t, err)
defer func() { testutil.Ok(t, os.RemoveAll(prepareDir)) }()
ctx, cancel := context.WithTimeout(context.Background(), 20*time.Second)
defer cancel()
for _, b := range blocks {
var id ulid.ULID
var err error
if b.numSamples == 0 {
id, err = e2eutil.CreateEmptyBlock(prepareDir, b.mint, b.maxt, b.extLset, b.res)
} else {
id, err = e2eutil.CreateBlock(ctx, prepareDir, b.series, b.numSamples, b.mint, b.maxt, b.extLset, b.res)
}
testutil.Ok(t, err)
meta, err := metadata.Read(filepath.Join(prepareDir, id.String()))
testutil.Ok(t, err)
metas = append(metas, meta)
testutil.Ok(t, block.Upload(ctx, log.NewNopLogger(), bkt, filepath.Join(prepareDir, id.String())))
}
return metas
}
// Regression test for #2459 issue.
func TestGarbageCollectDoesntCreateEmptyBlocksWithDeletionMarksOnly(t *testing.T) {
logger := log.NewLogfmtLogger(os.Stderr)
objtesting.ForeachStore(t, func(t *testing.T, bkt objstore.Bucket) {
ctx, cancel := context.WithTimeout(context.Background(), 120*time.Second)
defer cancel()
// Generate two blocks, and then another block that covers both of them.
var metas []*metadata.Meta
var ids []ulid.ULID
for i := 0; i < 2; i++ {
var m metadata.Meta
m.Version = 1
m.ULID = ulid.MustNew(uint64(i), nil)
m.Compaction.Sources = []ulid.ULID{m.ULID}
m.Compaction.Level = 1
ids = append(ids, m.ULID)
metas = append(metas, &m)
}
var m1 metadata.Meta
m1.Version = 1
m1.ULID = ulid.MustNew(100, nil)
m1.Compaction.Level = 2
m1.Compaction.Sources = ids
m1.Thanos.Downsample.Resolution = 0
// Create all blocks in the bucket.
for _, m := range append(metas, &m1) {
fmt.Println("create", m.ULID)
var buf bytes.Buffer
testutil.Ok(t, json.NewEncoder(&buf).Encode(&m))
testutil.Ok(t, bkt.Upload(ctx, path.Join(m.ULID.String(), metadata.MetaFilename), &buf))
}
blocksMarkedForDeletion := promauto.With(nil).NewCounter(prometheus.CounterOpts{})
garbageCollectedBlocks := promauto.With(nil).NewCounter(prometheus.CounterOpts{})
ignoreDeletionMarkFilter := block.NewIgnoreDeletionMarkFilter(nil, objstore.WithNoopInstr(bkt), 48*time.Hour)
duplicateBlocksFilter := block.NewDeduplicateFilter()
metaFetcher, err := block.NewMetaFetcher(nil, 32, objstore.WithNoopInstr(bkt), "", nil, []block.MetadataFilter{
ignoreDeletionMarkFilter,
duplicateBlocksFilter,
}, nil)
testutil.Ok(t, err)
sy, err := NewSyncer(nil, nil, bkt, metaFetcher, duplicateBlocksFilter, ignoreDeletionMarkFilter, blocksMarkedForDeletion, garbageCollectedBlocks, 1)
testutil.Ok(t, err)
// Do one initial synchronization with the bucket.
testutil.Ok(t, sy.SyncMetas(ctx))
testutil.Ok(t, sy.GarbageCollect(ctx))
testutil.Equals(t, 2.0, promtest.ToFloat64(garbageCollectedBlocks))
rem, err := listBlocksMarkedForDeletion(ctx, bkt)
testutil.Ok(t, err)
sort.Slice(rem, func(i, j int) bool {
return rem[i].Compare(rem[j]) < 0
})
testutil.Equals(t, ids, rem)
// Delete source blocks.
for _, id := range ids {
testutil.Ok(t, block.Delete(ctx, logger, bkt, id))
}
// After another garbage-collect, we should not find new blocks that are deleted with new deletion mark files.
testutil.Ok(t, sy.SyncMetas(ctx))
testutil.Ok(t, sy.GarbageCollect(ctx))
rem, err = listBlocksMarkedForDeletion(ctx, bkt)
testutil.Ok(t, err)
testutil.Equals(t, 0, len(rem))
})
}
func listBlocksMarkedForDeletion(ctx context.Context, bkt objstore.Bucket) ([]ulid.ULID, error) {
var rem []ulid.ULID
err := bkt.Iter(ctx, "", func(n string) error {
id := ulid.MustParse(n[:len(n)-1])
deletionMarkFile := path.Join(id.String(), metadata.DeletionMarkFilename)
exists, err := bkt.Exists(ctx, deletionMarkFile)
if err != nil {
return err
}
if exists {
rem = append(rem, id)
}
return nil
})
return rem, err
}