Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

receive: allow local tsdb compaction #1967

Merged
merged 1 commit into from Jan 8, 2020

Conversation

blockloop
Copy link
Contributor

@blockloop blockloop commented Jan 8, 2020

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Allow enabling local TSDB compaction. For some setups uploading is disabled and local compaction saves a good amount of disk space and query times.

Verification

Running a local build

@blockloop blockloop force-pushed the bjones/receive/allow-compaction branch from 7dcc920 to 9dfb199 Compare January 8, 2020 16:55
@blockloop blockloop changed the title Bjones/receive/allow compaction receive: allow local tsdb compaction Jan 8, 2020
@bwplotka bwplotka requested a review from squat January 8, 2020 17:06
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, I like this 👍

Build error though.

@blockloop blockloop force-pushed the bjones/receive/allow-compaction branch 2 times, most recently from 8075d6f to fd9b4a3 Compare January 8, 2020 17:44
Signed-off-by: Brett Jones <blockloop@users.noreply.github.com>
@blockloop blockloop force-pushed the bjones/receive/allow-compaction branch from fd9b4a3 to c3a9261 Compare January 8, 2020 20:52
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄‍♀️

@squat squat merged commit 1d71579 into thanos-io:master Jan 8, 2020
@blockloop blockloop deleted the bjones/receive/allow-compaction branch July 2, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants