Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add micro benchmarks to fetcher.go filters. #2174

Closed
bwplotka opened this issue Feb 24, 2020 · 9 comments · Fixed by #2466
Closed

Add micro benchmarks to fetcher.go filters. #2174

bwplotka opened this issue Feb 24, 2020 · 9 comments · Fixed by #2466

Comments

@bwplotka
Copy link
Member

bwplotka commented Feb 24, 2020

It would be awesome to learn if we need more concurrency etc there.

Those filters are critical for our components to learn about new blocks.

@grzkv
Copy link
Contributor

grzkv commented Feb 28, 2020

Are we primarily talking about benchmarking the Filter functions?

@bwplotka
Copy link
Member Author

That's correct, but maybe only for more complex ones. E.g like #2118

I no longer work on this, so feel free to grab this and finish 🤗

@grzkv
Copy link
Contributor

grzkv commented Mar 1, 2020

Great. I'll take it!

@bwplotka
Copy link
Member Author

bwplotka commented Mar 2, 2020

Awesome. Might be good to sync with @khyatisoneji, but she is busy recently so I am pretty sure she will be happy for you to continue benchmarking. (:

Feel free to checkout my branch and get all changes, then work on top of it (:

@yashrsharma44
Copy link
Contributor

Hey @bwplotka! I was wondering if this issue is not picked up yet, can I solve this issue? I will try and understand the requirements of this issue, before pushing in a PR!

@bwplotka
Copy link
Member Author

bwplotka commented Apr 1, 2020

Of crouse, go for it @yashrsharma44 if @grzkv is not active 👍

You can see the #2118 for some start.

@grzkv
Copy link
Contributor

grzkv commented Apr 7, 2020

@bwplotka @yashrsharma44 Sorry, I am short on time at least until the end of this week. Please feel free to pick it up.

@stale
Copy link

stale bot commented May 7, 2020

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label May 7, 2020
@stale
Copy link

stale bot commented May 14, 2020

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants