Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Swift integration tests #2829

Closed
GiedriusS opened this issue Jul 1, 2020 · 1 comment
Closed

Add Swift integration tests #2829

GiedriusS opened this issue Jul 1, 2020 · 1 comment
Assignees
@FUSAKLA
Labels
component: repo tools good first issue help wanted

Comments

@GiedriusS
Copy link
Member

Let's add Swift integration tests to our CI! It should be very easy with these environment variables plus the Docker image mentioned in this comment: #2665 (comment)

It ought to be enough to edit https://github.com/thanos-io/thanos/blob/master/.circleci/config.yml to start up another container that runs it, to remove SWIFT from the skipped objstore test list in the test-ci target, and to add these environment variables.

ACC:

  • Swift objstore tests run on our CI
@FUSAKLA FUSAKLA mentioned this issue Jul 2, 2020
Merged
@FUSAKLA FUSAKLA self-assigned this Jul 2, 2020
@GiedriusS
Copy link
Member Author

Closed by #2838.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FUSAKLA FUSAKLA

Labels
component: repo tools good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GiedriusS @FUSAKLA