Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a dark theme in UI #3775

Closed
appleciderjack opened this issue Feb 6, 2021 · 5 comments · Fixed by #4249
Closed

Implement a dark theme in UI #3775

appleciderjack opened this issue Feb 6, 2021 · 5 comments · Fixed by #4249

Comments

@appleciderjack
Copy link

Is your proposal related to a problem?

Similar to prometheus/prometheus#7735
It would be great to have a dark theme toggle in Thanos. (This is coming from SREs who use the Thanos UI to do digging more frequently than Grafana Explore tab)

A common use case is that we would take screenshots and post them in slack during the day.

Describe the solution you'd like

A dark mode toggle would be great, and make screenshots have less contrast when shared via Slack (in dark mode)

Describe alternatives you've considered

We use Grafana explore tab from time to time, but the experience is not as good comparing to Prometheus based UI.

Additional context

I am a monitoring SRE and often presents to team members who are new with Prometheus/Thanos/Grafana.
Slack/Grafana/Slides already supports dark mode, so it is the most jarring when switching to the Prometheus UI.

Once we get used to it, it's not so bad. But it would make for better new comer UX if we have it!

Thanks

@bwplotka
Copy link
Member

bwplotka commented Feb 7, 2021

I love this idea!

Can we propose this to Prometheus? We inherit Prometheus base! (: 🤗

@bwplotka
Copy link
Member

bwplotka commented Feb 7, 2021

Oh, actually there is already. Ok, let's wait until Prometheus have it, then we will port! Help wanted. Let's do it!

prometheus/prometheus#7735

@Aman-Codes
Copy link
Contributor

Hi @bwplotka
I am interested in working on this issue. Now as dark theme is added in Prometheus (#8604), so shall I start working on adding dark theme in Thanos UI?

@Aman-Codes Aman-Codes mentioned this issue May 19, 2021
2 tasks
@onprem
Copy link
Member

onprem commented May 19, 2021

This issue number is an anagram of prometheus/prometheus#7735

Coincidence? Dark theme magic.

@bwplotka
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants