Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucket rewrite: able to mark original blocks for deletion after new blocks are created #4387

Closed
yeya24 opened this issue Jun 30, 2021 · 4 comments

Comments

@yeya24
Copy link
Contributor

yeya24 commented Jun 30, 2021

Is your proposal related to a problem?

Bucket rewrite tool supports block deletion and relabeling. It creates a new block and the original block is left unchanged. Usually, the old block can be removed. But it requires another step to mark the original block.

Describe the solution you'd like

It would be handy to have a flag to mark the original blocks for deletion after the new blocks created successfully. This flag should work only in none dry run mode.

@yeya24
Copy link
Contributor Author

yeya24 commented Jun 30, 2021

Thoughts? @bwplotka @onprem @GiedriusS

@GiedriusS
Copy link
Member

Makes total sense. For some reason I thought that we were doing this automatically already

@yeya24 yeya24 self-assigned this Jul 1, 2021
@yeya24
Copy link
Contributor Author

yeya24 commented Jul 1, 2021

Assign this myself.

@GiedriusS
Copy link
Member

Fixed in #4392.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants