Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query: present_over_time function suggested by autocompletion but not yet implemented #4665

Closed
jmichalek132 opened this issue Sep 16, 2021 · 1 comment · Fixed by #4669
Closed

Comments

@jmichalek132
Copy link
Contributor

jmichalek132 commented Sep 16, 2021

Thanos, Prometheus and Golang version used: Thanos v0.23.0-rc.0, Prometheus v2.29.1, Go 1.16.5

Object Storage Provider: S3 compatible storage

What happened:
After upgrading Prometheus & Thanos to make use of new promql function present_over_time which was introduced in Prometheus version 2.29.0, I tried to use it in Thanos query as it was also suggested by the autocompletion.

Screenshot 2021-09-13 at 15-22-32 Thanos Highly available Prometheus setup

However trying to use it results in error unknown function with name present_over_time.

Screenshot 2021-09-13 at 15-22-55 Thanos Highly available Prometheus setup

This is most likely caused by only the ui dependency on Prometheus actually being updated. PR updating the codemirror-promql dependency.

What you expected to happen: Either not getting the suggestion for the function, or getting the suggestion and the function actually being available to use.

How to reproduce it (as minimally and precisely as possible): Deploy thanos query with version v0.23.0-rc.0 and try to use the present_over_time function.

Full logs to relevant components:

Anything else we need to know:

@yeya24
Copy link
Contributor

yeya24 commented Sep 16, 2021

Looks like the lezer promql version is newer then our prometheus package version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants