Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to "thanos tools bucket ls" to exclude marked blocks #4929

Closed
snuggie12 opened this issue Dec 8, 2021 · 2 comments · Fixed by #4970
Closed

Add flag to "thanos tools bucket ls" to exclude marked blocks #4929

snuggie12 opened this issue Dec 8, 2021 · 2 comments · Fixed by #4970

Comments

@snuggie12
Copy link

Is your proposal related to a problem?

I was trying to prepare a for loop to do rewrites and accidentally did rewrites on blocks that were marked for deletion. This ended up creating overlaps which prevented compactor from starting up.

Describe the solution you'd like

It'd be nice if ls had an option to exclude blocks marked for deletion.

Describe alternatives you've considered

Alternatively maybe rewrite should refuse to rewrite a block marked for deletion?

@yeya24
Copy link
Contributor

yeya24 commented Dec 8, 2021

@snuggie12 Makes sense. This filtering can be done at the fetcher filters. Help wanted!

@metonymic-smokey
Copy link
Contributor

@snuggie12 , just to clarify, ls will also need an option for deleteDelay too right, since blocks marked for deletion are filtered based on the delay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants