Remove constant spam of "changing probe status"

[GiedriusS]

With Sidecar now changing its readiness status depending on whether it can establish a connection with Prometheus, there is spam of:

{"caller":"intrumentation.go:48","level":"info","msg":"changing probe status","status":"ready","ts":"2022-01-06T16:37:27.595400008Z"}

We shouldn't print this message if the status is set to the same value as the previous one.

[AvineshTripathi]

Hey @GiedriusS very new here is this something I can go for without knowing the codebase

[GiedriusS]

Yep.

thanos/pkg/prober/intrumentation.go

Line 48 in e03452e

level.Info(p.logger).Log("msg", "changing probe status", "status", "ready")

here we need to introduce a new variable in InstrumentationProbe called ready or something. Like here:

thanos/pkg/prober/http.go

Lines 19 to 20 in 19dcc79

	ready atomic.Uint32
	healthy atomic.Uint32

. And then check in Ready() if we weren't ready before. If true then print. Same with NotReady().

[AvineshTripathi]

okay i ll go for this please assign me

[AvineshTripathi]

Hey @GiedriusS I have done some changes but not sure if that is working can you tell how do I check it

[GiedriusS]

Run the quickstart script or in some other way, or manually a pair of Thanos Query+Sidecar (& Prometheus). If everything is ok then you won't see a constant spam as in the original description.

[JuozasVainauskas]

@AvineshTripathi are You still working on this and planning to finish it or can I open a PR with my fix for this issue?

[AvineshTripathi]

Hey @JuozasVainauskas I have done the changes but not able to set up in my local device so I think you should go for the PR i ll unaaisgn myself
P.S. sorry for the trouble

[GiedriusS]

Fixed in #5051