Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query: metadata endpoint /api/v1/label/<label_name>/values should return external labels #649

Closed
FUSAKLA opened this issue Nov 27, 2018 · 2 comments · Fixed by #655
Closed

Comments

@FUSAKLA
Copy link
Member

FUSAKLA commented Nov 27, 2018

The metadata endpoint of Thanos Query /api/v1/label/<label_name>/values should return all values of the specified label name. (see Prometheus docs).

This works for all labels but not for the labels specified added by the external_labels of Thanos Store instances.

This is used for example by Grafana in label_values(<label_name>) which can be used to load lavel values to query variable see http://docs.grafana.org/features/datasources/prometheus/#query-variable.

@bwplotka
Copy link
Member

Thanks, valid issue, PRs welcome (:

@bwplotka bwplotka changed the title [Bug] Query: metadata endpoint /api/v1/label/<label_name>/values should return external labels query: metadata endpoint /api/v1/label/<label_name>/values should return external labels Nov 28, 2018
@bwplotka
Copy link
Member

The actual work to be done, is to glue external labels from blocks in store Gateway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants