Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support random delay before upload blocks on sidecar #7184

Open
Wing924 opened this issue Mar 6, 2024 · 2 comments
Open

Support random delay before upload blocks on sidecar #7184

Wing924 opened this issue Mar 6, 2024 · 2 comments

Comments

@Wing924
Copy link
Contributor

Wing924 commented Mar 6, 2024

Is your proposal related to a problem?

Currently, all sidecars upload blocks at the same time.
It make huge bandwidth usage to object storage.

It will be a problem when you run sidecars in on-premises and use public cloud object storage
because the dedicated line has limited bandwidth.

Describe the solution you'd like

I propose add some random delay before uploading blocks.

Let's dd the --shipper.upload-jitter flag.
When sidecar upload blocks, it sleep random time between 0 and jitter.

Describe alternatives you've considered

I tried to manage QoS, but it's very hard to config.

@yeya24
Copy link
Contributor

yeya24 commented Mar 6, 2024

I think it is ok to add some jitter when uploading blocks. The question is, do we add jitter to the shipper itself? I understand we want to jitter the caller loop. For example, in sidecar we will add it here.

https://github.com/thanos-io/thanos/blob/main/cmd/thanos/sidecar.go#L365

@Vanshikav123
Copy link
Contributor

Hello ! @yeya24 can i work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants