Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Restructure JSON-RPC directory and rename server config #400

Closed
fedekunze opened this issue Aug 5, 2021 · 1 comment · Fixed by #612
Closed

Restructure JSON-RPC directory and rename server config #400

fedekunze opened this issue Aug 5, 2021 · 1 comment · Fixed by #612
Assignees
@danburck
Labels
C:JSON-RPC JSON-RPC client good first issue Good for newcomers help wanted Extra attention is needed

Comments

@fedekunze
Copy link
Contributor

fedekunze commented Aug 5, 2021 •
edited
Loading

given that we are supporting additional namespaces other than ethereum's now (eg: cosmos_ namespace #386), we should restructure the rpc directory in a more clear way:

rpc/
    ethereum/
       backend/
       namespaces/
          eth/ 
          ...
    cosmos/
       namespaces/
          cosmos/
    apis.go

Additionally, we should rename the EVMRPCConfig to JSONRPCConfig to reflect this change
@fedekunze fedekunze added good first issue Good for newcomers help wanted Extra attention is needed C:JSON-RPC JSON-RPC client labels Aug 5, 2021
@fedekunze fedekunze mentioned this issue Aug 6, 2021
Closed
11 tasks
@crypto-facs crypto-facs self-assigned this Aug 8, 2021
@crypto-facs
Copy link
Contributor

I will take this issue as I am currently restructuring this area for the debug namespace

@danburck danburck mentioned this issue Oct 1, 2021
Merged
11 tasks
danburck added a commit that referenced this issue Oct 1, 2021
@danburck
Add #400 to changelog
b379180
danburck added a commit that referenced this issue Oct 1, 2021
@danburck
Move #400 to unreleased section
4635c46
fedekunze pushed a commit that referenced this issue Oct 1, 2021
@danburck
rpc: restructure JSON-RPC directory and rename server config (#612)
34c2593 
* Restructure ethermint/rpc repo structure and change import statements

* Add #400 to changelog

* fix filepath in util and json_rpc

* Move #400  to unreleased section
fedekunze pushed a commit that referenced this issue Oct 7, 2021
@danburck @fedekunze
rpc: restructure JSON-RPC directory and rename server config (#612)
83d247d 
* Restructure ethermint/rpc repo structure and change import statements

* Add #400 to changelog

* fix filepath in util and json_rpc

* Move #400  to unreleased section
fedekunze added a commit that referenced this issue Oct 7, 2021
@fedekunze @dependabot
@danburck @yihuang @davcrypto
release: v0.7.0 cherry picks (#645)
de83c87 
* docs: v0.6.0 changelog (#605) (#606)

* docs: v0.6.0 changelog

* update codeowners

* build(deps): bump github.com/cosmos/cosmos-sdk from 0.44.0 to 0.44.1 (#610)

* build(deps): bump github.com/cosmos/cosmos-sdk from 0.44.0 to 0.44.1

Bumps [github.com/cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) from 0.44.0 to 0.44.1.
- [Release notes](https://github.com/cosmos/cosmos-sdk/releases)
- [Changelog](https://github.com/cosmos/cosmos-sdk/blob/v0.44.1/CHANGELOG.md)
- [Commits](cosmos/cosmos-sdk@v0.44.0...v0.44.1)

---
updated-dependencies:
- dependency-name: github.com/cosmos/cosmos-sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* changelog

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>

* cmd: use config on genaccounts (#483)

* cmd: use config on genaccounts

* update

* c++

* rpc: fix panic (#611)

* rpc: fix panic

* fix

* c++

* rpc: restructure JSON-RPC directory and rename server config (#612)

* Restructure ethermint/rpc repo structure and change import statements

* Add #400 to changelog

* fix filepath in util and json_rpc

* Move #400  to unreleased section

* evm: refactor `traceTx` (#613)

* DNM: debug traceTx

* c++

* deps: bump IBC-go (#621)

* deps: bump IBC-go

* changelog

* evm, rpc:  fix tx log attribute value is not parsable by some client (#615)

* Problem: tx log attribute value not parsable by some client

Closes: #614

Solution:
- encode the value to json string rather than bytes

Apply suggestions from code review

* rm cdc and changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>

* evm: fix iterator on deeply nested cache contexts (#617)

* Problem: iterator on deeply nested cache contexts is extremely slow

Closes: #616

Solution:
- flatten cache contexts before doing `GetTxLogsTransient`

* Update x/evm/keeper/context_stack.go

* changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <federico.kunze94@gmail.com>

* evm: add benchmark for deep context stack (#627)

* Problem: deep context stack efficienty is not benchmarked

Closes: #626

Solution:
- add a benchmark to demonstrate an extremely inefficiency in deep
  context stack

* Update x/evm/keeper/benchmark_test.go

* prefix storage is irrelevant

* add comment to state_transition.go

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* rpc: support personal apis with different keyring backends (#591)

* UPDATE Unlock keyring on start

* ADD comment

* ADD validation

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* conflicts

* changelog

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: davcrypto <88310031+davcrypto@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@danburck danburck

Labels
C:JSON-RPC JSON-RPC client good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restructure JSON-RPC directory and rename server config evmos/ethermint
3 participants
@fedekunze @danburck @crypto-facs