Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix: Some fields in transaction are not authenticated by signature #703

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

adu-web3
Copy link
Contributor

@adu-web3 adu-web3 commented Oct 26, 2021

Closes: #426

Description

Sorry for accidentally closing the PR #689 .
The separate test for comparing signatures in cosmos tx , MsgEthereumTx and eth tx has been added.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #703 (2fdce87) into main (fd36873) will decrease coverage by 0.02%.
The diff coverage is 56.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
- Coverage   56.41%   56.39%   -0.03%     
==========================================
  Files          64       64              
  Lines        5637     5710      +73     
==========================================
+ Hits         3180     3220      +40     
- Misses       2271     2298      +27     
- Partials      186      192       +6     
Impacted Files Coverage Δ
app/ante/eth.go 82.28% <56.00%> (-5.92%) ⬇️
app/ante/ante.go 48.19% <100.00%> (ø)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, can you add a changelog entry?

@adu-web3
Copy link
Contributor Author

adu-web3 commented Nov 8, 2021

ACK, can you add a changelog entry?

changelog entry is added, please review and inform me if any correction is need. @fedekunze

@fedekunze fedekunze merged commit e04422b into evmos:main Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some fields in transaction are not authenticated by signature
2 participants