Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(vesting): add authz msg check on ante handler #318

Merged
merged 6 commits into from Mar 1, 2022

Conversation

danburck
Copy link
Contributor

@danburck danburck commented Mar 1, 2022

Description

Adds msg authorization check in vesting ante

@danburck danburck marked this pull request as ready for review March 1, 2022 16:38
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #318 (6522855) into main (b71526c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 6522855 differs from pull request most recent head 380ff59. Consider uploading reports for the commit 380ff59 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   65.04%   65.05%           
=======================================
  Files          93       93           
  Lines        6191     6192    +1     
=======================================
+ Hits         4027     4028    +1     
  Misses       2007     2007           
  Partials      157      157           
Impacted Files Coverage Δ
app/app.go 84.13% <100.00%> (+0.02%) ⬆️

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs to also added to NewValidatorCommissionDecorator

app/ante/handler_options.go Outdated Show resolved Hide resolved
app/ante/vesting.go Outdated Show resolved Hide resolved
@fedekunze fedekunze changed the title bug(vesting): add ante msg authorization bug(vesting): add authz msg check on ante handler Mar 1, 2022
@fedekunze fedekunze enabled auto-merge (squash) March 1, 2022 21:15
@fedekunze fedekunze merged commit 8e1823c into main Mar 1, 2022
@fedekunze fedekunze deleted the add-ante-msg-authorization branch March 1, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants