bugfix: Update utils.go #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugfix: compare 2 DenomUnit variable wrong because they are pointers
danburck
reviewed
Apr 26, 2022
decimals := uint8(coinMetadata.DenomUnits[0].Exponent) The original code maybe OK for evmos itself. However, it may causes incorrect decimal value 1. in the metadata validation func: cosmos-sdk/x/bank/types/metadata.go: Metadata.Validate() it makes sure Denomination units are sorted in ascending order. 2. https://docs.evmos.org/modules/erc20/01_concepts.html "Coin Metadata to ERC20 details" informaiton
|
@danburck thanks for your review, I have added the test code in I have submit another commit about fetch "decimal" value from cosmos coin metadata during deploy ERC20 contract. |
fedekunze
reviewed
Apr 27, 2022
Codecov Report
@@ Coverage Diff @@
## main #530 +/- ##
==========================================
+ Coverage 81.46% 81.56% +0.10%
==========================================
Files 115 115
Lines 6360 6375 +15
==========================================
+ Hits 5181 5200 +19
+ Misses 1024 1018 -6
- Partials 155 157 +2
|
fedekunze
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix: compare 2 DenomUnit variable wrong because they are pointers
Description
Closes: #XXX
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdCode maintenance:
I have...
godocand code comments.docs/) or specification (x/<module>/spec/)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...