Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

02-first-java Programs Not Matching With Kunal's Questions #65

Closed
Lyon03 opened this issue Jan 29, 2022 · 5 comments
Closed

02-first-java Programs Not Matching With Kunal's Questions #65

Lyon03 opened this issue Jan 29, 2022 · 5 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@Lyon03
Copy link

Lyon03 commented Jan 29, 2022

For example,
The code given in the file 02-first-java for Q1.java is the code that gives the factorial of a number. Whereas in Kunal's assignment the corresponding question is to check whether a number is odd or eve which is done in Q2.java.

I found this to be the issue for multiple questions. I would love to be assigned to fix it.

@thatbeautifuldream
Copy link
Owner

I've been busy with a lot of other work related to college and haven't been able to make time fix these. There might have been assignment changes itself, earlier when the course started the assignments were different people have been contributing to Kunals repository as well that's why might be. Yes definitely you can just send a PR and I'll be more than happy to merge it.

@Lyon03
Copy link
Author

Lyon03 commented Jan 29, 2022

Awesome! I'll try my best :)

@thatbeautifuldream thatbeautifuldream added the help wanted Extra attention is needed label Jan 29, 2022
@VishwaS-22
Copy link

Hey @Lyon03! Are you currently working on this Issue? If not @thatbeautifuldream please assign this Issue to me. I've codes that currently matches Kunal's DSA-Java Bootcamp. Can I create a PR for this?

Thank you!

@thatbeautifuldream
Copy link
Owner

thatbeautifuldream commented Oct 29, 2022

You can make a PR for the same, thank you for your contribution. @VishwaS-22

@VishwaS-22
Copy link

Hey @thatbeautifuldream! I made a PR for that, Please check it. Am very much happy to contribute. Hope this will help the folks.
If any changes required means please feel free to share, I'm very much happy to help.

Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants