-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error after installing (Kirby 3) with PHP < 7.3 #53
Comments
Hi, can you give me some more information? You’re using v3.0.0-beta.1, right? Did you install the plugin with composer? Do you have any line and file numbers of the two errors above? Thank you! Just a wild guess: Do you have an active user in the Kirby panel? It seems that the error happens when writing the commit massage and adding the users information as git author (which is the only part where the plugin calls a |
Thank you for your reply! |
Did you manage to find the error in the last couple of days? I’m back from vacations so if you manage to get it working do you want to share the solution? Otherwise: Is it possible to get access to your installation / code? |
I still get the same error. |
I’ll try to test your starterkit setup tonight, maybe i’ll bee able to reproduce your error! |
Any update on this? I just tried again and still can't get it to work.
Every time I try to save, I get an error |
Update: I used PHP 7.1. I upgraded to 7.3 and the plugin now works. Also, I noticed I had to use a URL of the kind |
Sorry for not replying, I totally forgot to replay to this issue! We will definitely have a look to support PHP 7.1, this should be the minimum required version. You might also want to switch from tag v3.0.0-beta.1 to dev-kirby3 for now because this branch already contains some small fixes. |
Sweet! Thank you. I switched to FYI, I tried both 7.1 and 7.2 with dev-kirby3 and got the same error as before. For me it only works with PHP 7.3. |
We’ll try! :) Actually I’m waiting for feedback from Wottpal (who forked this plugin) if we should join forces on a Kirby git plugin. But have not heard from him for a couple of weeks. Because of this currently we're just doing very little development on our plugin so that we do not have to do things twice. |
Currently running into a similiar error
A properly working version of this would be amazing! |
@robinscholz This seems not to be related to this issue. It seems to me that the user running your web server does not have credentials to push to the remote repository. |
Could it be related to this?
|
@thathoff This happens locally, while running kirby via valet. Any idea how to solve this? |
Hmm, we do everything with docker here, so I don’t know the details how valet works. Does valet run the code as the local user or as an nginx user? In the latter case you might want to |
Seems to be a valet problem: laravel/valet#293 Running the plugin on a localhost server with |
Not entirely sure if this was the final fix, but adding my SSH Key to the mac keychain seemed to have worked: https://help.github.com/en/articles/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent#adding-your-ssh-key-to-the-ssh-agent |
Glad I found this. I was also getting the array to string conversion error:
Upgrading to PHP 7.3 did the trick. Now on to making this work on the remote server... |
Since PHP versions < 7.3 are EOL i’ll close this issue. |
The error message when I save a page is:
I use a custom public folder setup, as described here, but it shouldn't create any problem. I also tried to move the "content" folder to its default location, but no luck.
Edit: I tried to set it up with a fresh Starterkit and get this when I save a page:
The text was updated successfully, but these errors were encountered: