Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox: Subtitle resolution does not adapt to video #9

Closed
Arnagos opened this issue Aug 30, 2022 · 5 comments
Closed

Firefox: Subtitle resolution does not adapt to video #9

Arnagos opened this issue Aug 30, 2022 · 5 comments

Comments

@Arnagos
Copy link

Arnagos commented Aug 30, 2022

The subtitle resolution does not adapt to the video resolution leading to extremely low-quality subtitles.
So far only been observed in Firefox.

Example:
image

@ThaUnknown
Copy link
Owner

I assume this is firefox being shit and not to spec, and not firing the resize event on the video, I'll patch this

@Arnagos
Copy link
Author

Arnagos commented Aug 30, 2022

The OffscreenCanvas is not ready yet. Disabling the feature in the about:config fixes this issue.

@Arnagos Arnagos closed this as completed Aug 30, 2022
@GizmoTjaz
Copy link
Contributor

Support for OffscreenCanvas was added in Firefox 105, yet the issue still persists with the following error:

2022-10-23 16-00-13

@ThaUnknown
Copy link
Owner

Support for OffscreenCanvas was added in Firefox 105, yet the issue still persists with the following error:

2022-10-23 16-00-13

then they didn't do it right

@ThaUnknown
Copy link
Owner

OffscreenCanvas is a brand new feature, just like local font access, this shit will happen, which is why I left settings for the developers to toggle them themselves if they so see fit. Supporting experimental API's is always risky but rewarding, if you find a fix for this feel free to PR it but to my knowledge I did everything according to spec, so ff is more to blame than anything since this suggests u cant resize offscreen canvases, which is bs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants