Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ARM? #10

Open
saimon-moore opened this issue Nov 29, 2022 · 9 comments
Open

Support for ARM? #10

saimon-moore opened this issue Nov 29, 2022 · 9 comments

Comments

@saimon-moore
Copy link

Hi,

I just tried this on an M1 and it crashes with a segfault just as soon as I try to open a folder exported with https://github.com/rusq/slackdump/blob/master/doc/usage-export.rst#export-types (standard export)

Screenshot 2022-11-29 at 09 48 47

Screenshot 2022-11-29 at 09 48 22

Any chance, a build for arm will become available soon?

@thayakawa-gh
Copy link
Owner

Hi, @saimon-moore. Sorry for the inconvenience.
Because I will be very busy for the next few months, I can't release it right away.
In SlackLogViewer, Qt5 is used as a GUI toolkit, but it doesn't seem to support Apple Silicon natively, so I have to upgrade the Qt version to 6. In addition, I don't have a mac so I can't easily build/test. I need someone's help to release the binary.
From the above, I don't know when I will be able to work on it. I hope you will wait for a while until I can make time to do so.

@saimon-moore
Copy link
Author

Yes I will wait patiently. Unfortunately I don't have the chops to try it myself :(

Thank you very much

@norim13
Copy link

norim13 commented Feb 26, 2023

Hey 👋 I haven't run any C code since college, so my knowledge is pretty much gone, but if someone can give me some guidance I can help try to build this on Apple silicon.

(getting the segmentation fault myself too)

@thayakawa-gh
Copy link
Owner

Hi, saimon-moore and norim13. Sorry for my late reply.
Now I've got some time and started working on migration of SlackLogViewer to Qt6.
I'll provide you a pilot version soon, so it would be helpful if you could test it on Apple Silicon.

@thayakawa-gh
Copy link
Owner

Now test builds (using Qt5 or Qt6) for macOS are available. They can be downloaded from the links -> Artifacts -> macos or macos-qt6.
Could you try them on your mac?

@norim13
Copy link

norim13 commented May 5, 2023

Just tried both, but unfortunately I think none worked 😕 It crashes immediately once I select the folder I want to open. Is there any way for me to give you better data about the actual error? Any logs I can fetch somewhere?

(btw, apologies for taking so long... only saw this now 🤦)

@thayakawa-gh
Copy link
Owner

Hmm, the cause of the crash should be isolated first.

  1. Apple silicon
    We need someone to test the latest SlackLogViewer on both apple silicon and intel cpu.
  2. Problems with the export file formatting
    If you have export files from various workspaces, it would be helpful if you could test as many of them as possible.
  3. Simple bugs in SlackLogViewer
    I think this is the most likely scenario. I'm working on adding a function to display error messages when critical problems occur.

In fact, it would be great if someone could debug it on mac...

@sclsj
Copy link

sclsj commented May 4, 2024

Since this issue hasn't been closed, I assume you would still need someone to test on Apple Silicon? I have a m1 max macbook and is glad to help.

@sclsj
Copy link

sclsj commented May 4, 2024

Also, have you considered releasing two versions (two .tar.xz files or two .apps in one .tar.xz file in this case), one for each architecture? Personally I generally dislike Universal Binaries because it wastes space while adding no real benefit to me, and it seems to complicate the build process sometimes, I heard. It seems like both sides have a valid argument, and I've seen big companies taking different approaches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants