New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Family Param to /api/pairing #103

Open

rainrivas opened this issue Jan 29, 2018 · 1 comment

Assignees

Labels

backend

Milestone

Contributor

rainrivas commented Jan 29, 2018

Currently /api/pairing only expects budget as mandatory.
Proposal:

Add family param as optional
- If only family is present, read the budget from wishlistTotalCost
Set budget param as option
- If only budget is present, return all donors that match budget (working right now)
Require 1 of the 2 params to be present
- If either is missing, send 400

rainrivas added this to the Sprint 2 milestone

rainrivas self-assigned this

rainrivas added the backend label

Contributor Author

rainrivas commented Feb 12, 2018

Adding family param to api/pairing might be invalid now that I've split things up as follows

/api/pairing/budget -- Calculates the donors that match a budget
/api/pairing/:familyId -- Takes family ID, grabs total wishlist cost and makes a call to /api/pairing/budget to find the list of donors that can afford the list

rainrivas modified the milestones: Sprint 2, Sprint 3

rainrivas modified the milestones: Sprint 3, Sprint 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment