Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Rage generation on damage received #235

Closed
GrenderG opened this issue Mar 20, 2022 · 2 comments
Closed

TODO: Rage generation on damage received #235

GrenderG opened this issue Mar 20, 2022 · 2 comments
Labels
easy difficulty This is an easy task good first issue Good for newcomers todo This is a task to be done

Comments

@GrenderG
Copy link
Member

GrenderG commented Mar 20, 2022

Describe what needs to be implemented or enhanced
Implement rage generation on damage received.

Expected end result
Rage users should see their rage increment when receiving damage (if conditions are met).

Guidance

  1. I assume a good place to implement it would be in receive_damage.
  2. We can use the Vanilla formulae.

EDIT: Please read #235 (comment) for further clarification of how it should work.

@GrenderG GrenderG added good first issue Good for newcomers easy difficulty This is an easy task todo This is a task to be done labels Mar 20, 2022
@GrenderG GrenderG changed the title Rage generation on damage received TODO: Rage generation on damage received Mar 20, 2022
@Fluglow
Copy link
Member

Fluglow commented Mar 20, 2022

Rage generation and decay behavior varies between warrior stances (ie. shapeshift form). Bear form does not describe how rage generation works, but could be for example assumed to be the same as battle stance. The spells only apply a shapeshift on the affected unit, so has_form would be used to determine how rage is generated.

Descriptions from Spell.dbc:
Defensive Stance (71): "A defensive stance that reduces rage decay when out of combat. Generate rage when you are hit."
Battle Stance (2457): "A balanced combat stance. Generate rage when hit and when you strike an opponent."
Berserker Stance (2458): "An aggressive stance. Generate rage when you strike an opponent."

@GrenderG
Copy link
Member Author

Fixed in #241.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy difficulty This is an easy task good first issue Good for newcomers todo This is a task to be done
Projects
None yet
Development

No branches or pull requests

2 participants