Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abilities don't take weapon skill into account #333

Closed
Dovvah opened this issue Jul 31, 2022 · 2 comments · Fixed by #855
Closed

Abilities don't take weapon skill into account #333

Dovvah opened this issue Jul 31, 2022 · 2 comments · Fixed by #855
Labels
bug Something isn't working core Issues related to the core programming

Comments

@Dovvah
Copy link

Dovvah commented Jul 31, 2022

At low weapon skill it should be pretty much impossible to hit, which is true for auto attacks but my abilities hit 100% of the time

video https://www.youtube.com/watch?v=nKzQIcQfKWY

@Dovvah Dovvah added the bug Something isn't working label Jul 31, 2022
@Fluglow
Copy link
Member

Fluglow commented Jul 31, 2022

#238 - spells (including abilities) can only result in a hit.

@Yushe Yushe added the core Issues related to the core programming label Aug 3, 2022
@GizzleBizzle
Copy link
Collaborator

I think it is because skill proficiency isn't taken into account when determining if the skill lands or not.

Weapon autoattacks are connected to the skill of the weapon used and it works fine.
Abilities and Spells each have their proficiency tag in their ingame tooltips (Like Fireball spell is a part of Fire Magic proficiency) and the game seems to skip it even If I learn the proficiency manually via command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Issues related to the core programming
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants