Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program fails to convert songs with symbols in the name #2

Closed
marcopg99 opened this issue Sep 13, 2021 · 4 comments
Closed

Program fails to convert songs with symbols in the name #2

marcopg99 opened this issue Sep 13, 2021 · 4 comments

Comments

@marcopg99
Copy link

When the song has "/" in the name (AC/DC for example):

  • Couldnt convert song [Errno 2] No such file or directory : file path.mp3

When the song has "?" in the name:

  • Couldnt convert song [Errno 22] Invalid argument: file path.mp3
@marcopg99
Copy link
Author

When it has ":" in the name, a file without extension is left in the download directory. No error message shown

@Vildis
Copy link

Vildis commented Sep 14, 2021

Windows doesn't allow the following characters in filenames:
/ \ ? % * : | < and > Wikipedia

Easiest fix is just to remove them in the code.

@Vildis
Copy link

Vildis commented Sep 14, 2021

Removing the characters might not work in all cases if the song name is only symbols.
No clue what to do then, song name would still show in file metadata.

@rickyrorton
Copy link
Collaborator

i did encounter the same problem and fixed it only for one character, ill do for the others too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants