Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I want an accurate and more concise representation of the labels signaling the purchase urgency #39

Closed
2 tasks
yiremorlans opened this issue May 23, 2023 · 0 comments · Fixed by #40
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@yiremorlans
Copy link
Collaborator

yiremorlans commented May 23, 2023

Summary

Currently, the shopping list contains a legend with all the possible signals for a user to identify how soon they need to purchase an item in their list.

  • "Soon" represents within 7 days
  • "Kinda Soon" between 7 and 30 days
  • "Not Soon" between 30 and 60 days
  • "Inactive" been over 60 days since the last purchased
  • "Not yet purchased" to show an item not yet purchased

Reduce the number of labels for the user to keep track of to only essential as outlined in issue #12. Also required to address the bug where a user adds an item to be purchased "Not Soon" being grouped with the "Kinda Soon" items.

Screenshot 2023-05-23 at 2 34 22 PM

Acceptance criteria

  • The legend will have only four labels: Soon, Kinda Soon, Not Soon, and Inactive.
  • Address the bug that is causing newly added "Not Soon" items to be grouped with the "Kinda Soon" category.

Notes

What functions are handling dates from our backend and how are they being rendered on the front end? Address any functions with similar behaviors. The proposed solution for incorrect grouping of items is to round up(Math.ceil) instead of down for getDaysBetweenDates. (Thanks @drakenguyen4000 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
1 participant