Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed column name is not changed in the data_rows table. #3633

Open
BoFiaZ opened this issue Oct 15, 2018 · 3 comments
Open

Changed column name is not changed in the data_rows table. #3633

BoFiaZ opened this issue Oct 15, 2018 · 3 comments
Labels

Comments

@BoFiaZ
Copy link

BoFiaZ commented Oct 15, 2018

Version information

  • Laravel: v5.7
  • Voyager: v1.1
  • PHP: 7.1.3
  • Database: MySQL 5.6

Description

If the column name of any table is changed, the name changes in the table, but not in the data_rows table.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Go to Tools > Database
  2. Click on Edit any table
  3. Change the name of a table column
  4. Click on Update Table
  5. In the data_rows table, look for the changed column name

Expected behavior

The changed column name must also be changed in the data_rows table.

@DrudgeRajen
Copy link
Contributor

Did you try by updating the Bread after updating and saving the table? After updating the table column, to make it in effect you need to update the bread as well.

@emptynick
Copy link
Collaborator

Those two things (database and bread) are independent from each other.
Thats why updating a table won't update the bread-settings.
Even if we would do that in any way, one could still rename the column through a DBMS.

@fletch3555
Copy link
Collaborator

I want to say we should make the database editor update the BREAD (via events so it remains very loosely coupled). But at the same time, it's possible we may drop the database editor for 2.0, so I don't want to put too much effort into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants