Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: critical vulnurability in Voyager Compass #4322

Closed
V1ru55Z opened this issue Aug 8, 2019 · 4 comments
Closed

Security: critical vulnurability in Voyager Compass #4322

V1ru55Z opened this issue Aug 8, 2019 · 4 comments

Comments

@V1ru55Z
Copy link

V1ru55Z commented Aug 8, 2019

Version information

  • Laravel: v5.8.30
  • Voyager: v1.2.6
  • PHP: 7.2.19
  • Database: MySQL 5.7.27

Description

During pentesting some projects, i found critical vulnerability in Voyager Compass. This vulnerability can give to anyone, who has permission to use compass, power of download and delete every file in the system if the user has permission for this operation in the system. This means, bad guy can steal .env file of your application and sign his own new session and cookie with secret application key or just drop your database knowing username and password of the database.

How can you reproduce it?

[[Redacted]]

How to fix it

This vulnerability has a high criticality and a CVSS score estimate to 6,5. For fix it, i recommend check is the final directory of the path is directory, that existing in the logs directory.

@fletch3555
Copy link
Collaborator

fletch3555 commented Aug 8, 2019

We would appreciate security issues like this being brought to our attention in a more private fashion to give us the opportunity to resolve it quickly without making the attack vector public knowledge. This is common practice when exploits are discovered.

We're looking into this now and will respond when reproduced.

@emptynick
Copy link
Collaborator

This was already discovered quite a while ago.
Because of that, the compass will be switched off when the app goes to production-mode.

@MrCrayon
Copy link
Collaborator

I'm closing this since as said now Compass is switched off by default in production mode and also since v1.4.0 with #4856 uses Artisan::call

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. If you have further questions please ask in our Slack group.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants