Fix BREAD Validation issues #1963 and #2179

[blitux]

Hello maintainers,

This is a cleaned up version of an PR I've sent before that fixes two BREAD validation issues:

Fixes #1963: Validation scroll to first error not work
Fixes #2179: Validation fails when display name and field name of a BREAD field don't match

Closes #2612

This uses custom attributes to show $field->display_name on validation error messages, and that's why I'm reverting #2077.

I hope this will be included in the next release as, currently, BREAD form validation is broken when display_name and field_name don't match.

Thank you in advance.

[fletch3555]

Looks like it should be good. I don't have time to test it, but perhaps @emptynick or @akazorg does. If one of them say it's good, I'll get this merged in.

Thanks!

[regiszanandrea]

Part of this PR is related to PR #2612.

[fletch3555]

@regiszanandrea, can you be more specific? Both PRs touch ~20 files, so it's a royal pain to truly compare them. What part of this is related to #2612?

[regiszanandrea]

@fletch3555 This part: "Validation fails when display name and field name of a BREAD field don't match". The only difference is that @blitux use JS. Personally, I think this PR, better, because it resolves two problems. If you accept this PR, you should close the #2612.

[vblinden]

This indeed fixes the problem. This also looks good too me @fletch3555.

[blitux]

Awesome guys, thank you for your time!

[blitux]

@fletch3555 @samtheson The PR 2198 should also be closed

[fletch3555]

Good catch, thanks @blitux

[gausam]

@fletch3555 @blitux Hey gents. Sorry was away on a long holiday and then came back to tight work in January. Back to a normal life starting next week. Thanks for all the work on this.

[fletch3555]

No problem, welcome back!

[gausam]

Thank ye!