Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ?? operator with isset way #3068

Merged
merged 3 commits into from Apr 25, 2018
Merged

Replace ?? operator with isset way #3068

merged 3 commits into from Apr 25, 2018

Conversation

cyrildewit
Copy link
Contributor

Fixes #3067

@fletch3555
Copy link
Collaborator

You didn't replace, you only added a line.

@cyrildewit
Copy link
Contributor Author

facepalm

@cyrildewit
Copy link
Contributor Author

This will still not fix his issue, because then we have to release a new version. Right?

@fletch3555
Copy link
Collaborator

We'll definitely have to release a new version, but I don't see that as a problem.

@fletch3555 fletch3555 merged commit b3caa3c into thedevdojo:1.1 Apr 25, 2018
@cyrildewit cyrildewit deleted the fix-3067 branch May 1, 2018 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fletch3555 fletch3555 fletch3555 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cyrildewit @fletch3555