Proposed fix for multiple image field quality setting #3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a duplicate PR of #3507 on the 1.1 branch as requested. The multiple image content type class ignores user defined quality settings. The class does an isset() check on the $options variable, which is not defined thus always returns false. As a result the $resize_quality variable is set to it's default of 75%. This PR fixes the conditional check.
fletch3555
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate PR of #3507 on the 1.1 branch as requested.
The multiple image content type class ignores user defined quality settings.
The class does an isset() check on the $options variable, which is not defined thus always returns false. As a result the $resize_quality variable is set to it's default of 75%.
This PR fixes the conditional check.