Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Multiple Issues in Media Manager #4000

Merged
merged 9 commits into from Mar 16, 2019
Merged

Fix Multiple Issues in Media Manager #4000

merged 9 commits into from Mar 16, 2019

Conversation

suxur
Copy link
Contributor

@suxur suxur commented Mar 12, 2019

Issues Fixed:

  • When creating folders in Firefox the name is "undefined"
  • When moving files in Firefox the selected destination returns "undefined"
  • Unable to use "command" or "meta" key for multi-selection of files
  • Using "meta key" brought to surface another issue where you could select the same file / folder multiple times.

Joshua Payne added 3 commits March 12, 2019 15:23
Add missing semi-colons
6b5dbe6
Allow cherry picking multi-select in media manager
517ff2f 
Prevent same file/folder from being selected multiple times
Fix issues when creating folders and moving files in Firefox
79eca43 
When trying to create a folder or moving a file, the name or destination
would return "undefined" when using Firefox. This replaces getting the
input value via jQuery and instead using Vue and it's v-model binding.
Joshua Payne added 2 commits March 13, 2019 11:34
Fix scope reference to this
51f014c
Prevent empty field being submitted when moving files
5c7ea4a 
Add "disabled" to move file default option. This prevents someone from
selecting this option after they have selected another option. Check
for an empty destination before submitting the post request to move
the file or folder.
@emptynick emptynick merged commit c4038dc into thedevdojo:1.2 Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emptynick emptynick emptynick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@suxur @emptynick