Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide delete button when has no delete permission #4292

Merged
merged 1 commit into from Jul 28, 2019
Merged

Hide delete button when has no delete permission #4292

merged 1 commit into from Jul 28, 2019

Conversation

nysso
Copy link
Contributor

@nysso nysso commented Jul 27, 2019

Hide delete button in Settings page when the user has no delete settings permission.
So instead of the forbidden action exception (code 403),
the user won't be able to see/click the delete button

@fletch3555
Copy link
Collaborator

Good find! Not sure how that one slipped past us.

@fletch3555 fletch3555 merged commit 3229e73 into thedevdojo:1.2 Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants