Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support database table prefix in connection #4546

Merged
merged 2 commits into from Dec 18, 2019

Conversation

MrCrayon
Copy link
Collaborator

@MrCrayon MrCrayon commented Nov 7, 2019

Currently, even fixing the error in install, if prefix is set in database configuration Voyager BREAD management doesn't work:

  • BREADs are not recognized
  • Trying to add or edit BREAD will not show fields

This PR fixes that and makes the use of prefix transparent for the user that will only see table prefix while editing or creating tables, in that case prefix need to be used in Table Name field

Fixes #4541

@enniosousa if you need to use table prefix in connection you could try this PR.

Currently, even fixing the error in install, if prefix is set in database configuration Voyager BREAD management doesn't work:

- BREADs are not recognized
- Trying to add or edit BREAD will not show fields

This PR fixes that and makes the use of prefix transparent for the user that will only see table prefix while editing or creating tables, in that case prefix need to be used in Table Name field
@MrCrayon MrCrayon force-pushed the support-global-database-prefix branch from 3913a9f to b8791f7 Compare December 18, 2019 12:15
@fletch3555 fletch3555 merged commit ba9e657 into thedevdojo:1.3 Dec 18, 2019
@MrCrayon MrCrayon deleted the support-global-database-prefix branch December 19, 2019 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: database prefix on run php artisan voyager:install
2 participants