Update Voyager.php // setting function #4764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the method all() does not order the settings keys according to the admin sort.
example if someone wants to loop some settings with exact order will be difficult example,
Create Setting Social Media -- it has many keys Facebook, Twitter, Instagram, etc...
@foreach(setting('socaillinks') as $keySocail => $valueSocail )
@if($valueSocail)
<li><a href="{{$valueSocail}}"><i class="fab fa-{{$keySocail}}"></i></a></li>
@endif
@Endforeach
i will not be ordered as in admin
so i think it better as we have admin order to have this option also on setting function !
thanks a lot
Codecov Report
@@ Coverage Diff @@
## 1.4 #4764 +/- ##
=========================================
Coverage 60.37% 60.37%
Complexity 1370 1370
=========================================
Files 194 194
Lines 3990 3990
=========================================
Hits 2409 2409
Misses 1581 1581
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## 1.4 #4764 +/- ##
=========================================
Coverage 60.37% 60.37%
Complexity 1370 1370
=========================================
Files 194 194
Lines 3990 3990
=========================================
Hits 2409 2409
Misses 1581 1581
Continue to review full report at Codecov.
|
emptynick
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the method all() does not order the settings keys according to the admin sort.
example if someone wants to loop some settings with exact order will be difficult example,
Create Setting Social Media -- it has many keys Facebook, Twitter, Instagram, etc...
@foreach(setting('socaillinks') as $keySocail => $valueSocail )
@if($valueSocail)
@endif
@Endforeach
i will not be ordered as in admin
so i think it better as we have admin order to have this option also on setting function !
thanks a lot