Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTS #136

Open
2 tasks
Lyari-Elatha opened this issue Aug 1, 2022 · 1 comment
Open
2 tasks

TESTS #136

Lyari-Elatha opened this issue Aug 1, 2022 · 1 comment

Comments

@Lyari-Elatha
Copy link
Contributor

  • fix preexisting unit tests
  • create unit tests that are missing
@samuelgrant
Copy link
Contributor

samuelgrant commented Aug 17, 2022

Would recommend adding a GH Action to test the build process of backend/ when PRs are opened against Main.

I ran into an issue with PR #140 where code would compile in my dev environment, but another contributor had issues. It looks like the latest version of Rust might be more forgiving and that I was using a feature that was introduced fairly recently that other collaborators might not have access to.

A GH Action that runs on pull_request: that installs the version of Rust that we use on prod could help us spot these issues before code is merged to main.


Edit: 06:51 18/8 - I worked out where the property issue was coming from, my database made use of different capitalisation than the migrations I wrote. However, the other issue still stands and I'd still suggest we add a workflow to test the backend code for compilation errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants