Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Theme Variants Repeat Background #918

Closed
TheCuteFoxxy opened this issue Feb 6, 2023 · 3 comments
Closed

Custom Theme Variants Repeat Background #918

TheCuteFoxxy opened this issue Feb 6, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@TheCuteFoxxy
Copy link

Describe the bug
Custom variants of the shipped themes, cause a repeated background, despite using identical image assets. This has been specifically observed on the "Blurred" theme and and themes using non-shipped assets.

To Reproduce
Steps to reproduce the behavior:

  1. Copy an existing theme
  2. Modify the styles.css to match LoveDark CSS
  3. Clear caches
  4. Select new theme
  5. Observe tiling

Expected behavior
The theme should cover the full viewport without repeating.

Screenshots
Correctly Displayed "LoveDark" theme
LoveDark

Incorrectly Displayed "Blurred" theme with custom css and shipped assets
BlurredDark

Incorrectly Displayed Custom theme with custom css and non-shipped assets
BlackWood

Please complete the following information:

  • Browser: Firefox 109.0 (64-bit)
  • PHP version: 7.4
  • SnappyMail Version: 2.25.4

Additional context
The CSS used in my dark variation of "Love" is identical to the CSS being used in the new theme variants.

@the-djmaze
Copy link
Owner

Correct. background-size: cover; will solve that.

@TheCuteFoxxy
Copy link
Author

Correct. background-size: cover; will solve that.

We thought so to, but it did not do so for us. Are you able to reproduce an instance of this working using the CSS?

@TheCuteFoxxy
Copy link
Author

We are using the following CSS for MAIN

	--main-color: #fff;
	--main-bg-color: #48525C;
	--main-bg-image: url("images/background.jpg");
	--main-bg-size: cover;

@the-djmaze the-djmaze added the enhancement New feature or request label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants