Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain or remove resolve => x => resolve(x) pattern #148

Closed
MagnusBrzenk opened this issue May 14, 2020 · 1 comment
Closed

Explain or remove resolve => x => resolve(x) pattern #148

MagnusBrzenk opened this issue May 14, 2020 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@MagnusBrzenk
Copy link

I looked very briefly at this project. But as soon as I got to this unfamiliar pattern:

resolve => (count: number) =>
  resolve(count)

... I gave up. Either explain why this resolve pattern is needed here (and not just e.g. a payload), or simplify your library. Life is too short to guess the coder's motivations.
@the-dr-lazy
Copy link
Owner

Looks like this is duplicate of #122.

@the-dr-lazy the-dr-lazy added the duplicate This issue or pull request already exists label May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@the-dr-lazy @MagnusBrzenk