fix: SelectBuilder should query all columns if none explicitly selected

the-gear · Nov 20, 2018 · 411af95 · 411af95
1 parent c6f5cfd
commit 411af95
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/src/pg-query-builder.ts b/src/pg-query-builder.ts
@@ -70,7 +70,7 @@ export default class SelectBuilder {
   createQuery() {
     let sql: SqlFragment[] = [
       this.command, // usually 'SELECT'
-      this.selection.join(', '),
+      this.selection.length ? this.selection.join(', ') : '*',
       this.tableSource ? `FROM ${this.tableSource}` : '',
       ...this.joins,
     ];

diff --git a/test/__snapshots__/pg-query-builder.test.ts.snap b/test/__snapshots__/pg-query-builder.test.ts.snap
@@ -60,3 +60,11 @@ SQL {
   FROM "testTable"
 } Arguments Array []
 `;
+
+exports[`SelectBuilder should query all columns if none explicitly selected 1`] = `
+SQL {
+  SELECT
+  *
+  FROM test
+} Arguments Array []
+`;
diff --git a/test/pg-query-builder.test.ts b/test/pg-query-builder.test.ts
@@ -14,6 +14,11 @@ describe('SelectBuilder', () => {
     expect(query).toMatchSnapshot();
   });
 
+  it('should query all columns if none explicitly selected', () => {
+    const query = new SelectBuilder('test');
+    expect(query).toMatchSnapshot();
+  });
+
   it('should create simple query', () => {
     const query = new SelectBuilder('"testTable"')
       .select('a, b')