Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up result #1

Closed
automata opened this issue Jun 16, 2015 · 3 comments
Closed

Clean up result #1

automata opened this issue Jun 16, 2015 · 3 comments

Comments

@automata
Copy link
Contributor

Now we have the following as result:

saliency:
  bounding_rect: <array of arrays as points> box around biggest salient region
  polygon: <array of arrays as points> approximate polygon around biggest salient region
  center: <array as point> center of biggest salient region
  radius: <number> radius of the approx enclosing circle around biggest salient region

We should have the following, preserving the original fields for a while:

saliency:
  bbox: <array of objects> box around all regions
  confidence: <number> inverse/normalized entropy of saliency map histogram
  regions: <array of objects> [ 
    bbox: <array of objects> box around salient region
    polygon: <array of objects> polygon around salient region
    center: <object> center point of salient region
    radius: <number> radius of the approx enclosing circle around salient region
  ]

In this way, we should remove saliency.bounding_rect, saliency.polygon, saliency.center and saliency.radius because a saliency is composed by many regions. The only information regarding all those regions is the saliency.bbox that encloses them. If one wants to draw or use polygon of the saliency, it should iterate over all saliency.regions's bboxes.

We also should have a standard object to bboxes ({x: ?, y: ?, width: ?, height: ?}) and points ({x: ?, y: ?}).

@forresto
Copy link

Would each object in regions also have confidence? Do low-confidence polygons expand the containing bbox?

@automata
Copy link
Contributor Author

No confidence for each region for now. We can see them as a group of pieces that builds the saliency.bbox. So saliency.bbox have all saliency.regions's bboxes inside. We can add confidence for each region in a future release and have a threshold to discard low confidence regions in saliency.bbox (?)

The real important information for now is saliency.bbox and we can display saliency.regions's bboxes in places like alan-view (however, the most informative thing there is scene). We can group saliency.regions's bboxes in a near future tho, probably making them a better saliency.polygon.

@automata
Copy link
Contributor Author

7586c53 implements this clean up and standardize bboxes/points, while keeping saliency.bounding_rect, saliency.polygon, saliency.center and saliency.radius, trying to smoothly migrate them to new fields on places like alan-view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants