Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for the bitstring module #358

Closed
xguerin opened this issue Feb 21, 2015 · 4 comments
Closed

Adding support for the bitstring module #358

xguerin opened this issue Feb 21, 2015 · 4 comments

Comments

@xguerin
Copy link
Contributor

xguerin commented Feb 21, 2015

The bitstring module is a lifesaver for those working with bit strings. Unfortunately, it introduces a syntax extension bitmatch that is not supported by Merlin. How much trouble would it be to support it ?

@trefis
Copy link
Contributor

trefis commented Feb 21, 2015

I will have a look during the week, but at this point it's very unlikely that we will implement support for a new camlp4 extension.
People should consider using PPX (if you have time, you could contribute a ppx extension for bitstring, match%bitstring ... with sounds fine), which is supported by merlin.

@gasche
Copy link
Member

gasche commented Feb 21, 2015

I created an issue on bitstring's upstream.

@xguerin
Copy link
Contributor Author

xguerin commented Feb 28, 2015

Thanks, although the bitstring project does not seem very active. I'll work on it. Side question: how do you specify PPX to merlin ? With EXT ? I am trying withppx_metaquot, but it does not seem to be working.

@trefis
Copy link
Contributor

trefis commented Mar 6, 2015

No, just add the package with PKG.
EXT is to be used only for camlp4 extensions.

I'm closing this issue as won't fix btw.
bitstring should switch to using ppx.

@trefis trefis closed this as completed Mar 6, 2015
@trefis trefis added the wontfix label Mar 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants